Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect executeInFileDir when 'Run Selection/Line in Python Terminal' #6632

Closed
bet4it opened this issue Jul 18, 2019 · 2 comments
Closed

Respect executeInFileDir when 'Run Selection/Line in Python Terminal' #6632

bet4it opened this issue Jul 18, 2019 · 2 comments
Labels
area-terminal feature-request Request for new features or functionality

Comments

@bet4it
Copy link

bet4it commented Jul 18, 2019

Currently thepython.terminal.executeInFileDir settings doesn't affect Run Selection/Line in Python Terminal ( executeSelectionInTerminal ).

Hope we can also call setCwdForFileExecution in initializeRepl to set cwd when python.terminal.executeInFileDir is enabled.
@bet4it bet4it added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Jul 18, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jul 18, 2019
@DonJayamanne DonJayamanne self-assigned this Jul 18, 2019
@brettcannon
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes your idea gets to help us make our decision.

@luabud
Copy link
Member

luabud commented Sep 17, 2019 •
edited
Loading

Thanks for the suggestion 👍 but we decided not to move forward with this idea for now, since you can just change the directory in the terminal manually (and then the extension will just paste in the selection).

@luabud luabud closed this as completed Sep 17, 2019
@ghost ghost removed the needs decision label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @DonJayamanne @bet4it @luabud