Add PythonEnvInfo-related helpers. #14051

ericsnowcurrently · 2020-09-23T03:28:41Z

This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included:

drop PythonEnvInfo.id property
make some internal helpers public

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
Title summarizes what is changing.
~~[ ] Has a news entry file (remember to thank yourself!).~~
Appropriate comments and documentation strings in the code.
~~[ ] Has sufficient logging.~~
~~[ ] Has telemetry for enhancements.~~
Unit tests & system/integration tests are added/updated.
~~[ ] Test plan is updated as appropriate.~~
~~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~~
~~[ ] The wiki is updated with any design decisions/details.~~

codecov-commenter · 2020-09-23T03:39:09Z

Codecov Report

Merging #14051 into main will increase coverage by 0.08%.
The diff coverage is 74.00%.

@@            Coverage Diff             @@
##             main   #14051      +/-   ##
==========================================
+ Coverage   59.85%   59.94%   +0.08%     
==========================================
  Files         704      705       +1     
  Lines       39015    39101      +86     
  Branches     5644     5667      +23     
==========================================
+ Hits        23354    23439      +85     
+ Misses      14438    14430       -8     
- Partials     1223     1232       +9

Impacted Files	Coverage Δ
src/client/pythonEnvironments/base/info/index.ts	`100.00% <ø> (ø)`
src/client/pythonEnvironments/base/locator.ts	`83.33% <ø> (ø)`
src/client/pythonEnvironments/legacyIOC.ts	`40.13% <13.33%> (+4.03%)`	⬆️
...ts/base/locators/composite/environmentsResolver.ts	`95.52% <66.66%> (-0.07%)`	⬇️
...ent/pythonEnvironments/discovery/locators/index.ts	`85.95% <66.66%> (-0.83%)`	⬇️
src/client/pythonEnvironments/base/info/env.ts	`36.79% <68.29%> (+14.87%)`	⬆️
src/client/common/utils/misc.ts	`72.72% <71.42%> (-0.61%)`	⬇️
...nts/base/locators/composite/environmentsReducer.ts	`94.93% <77.77%> (-0.07%)`	⬇️
src/client/pythonEnvironments/base/locatorUtils.ts	`98.03% <98.03%> (ø)`
...ient/pythonEnvironments/base/info/pythonVersion.ts	`66.66% <100.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2ed7a...fd5e37b. Read the comment docs.

src/client/pythonEnvironments/base/info/env.ts

karrtikr · 2020-09-23T17:15:04Z

src/client/pythonEnvironments/base/locator.ts

     */
-    old: PythonEnvInfo;
+    old?: PythonEnvInfo;


FWIW I don't think we neeed old at all. We normally use this to search for the environment which is to be replaced by update, but we can also use update to search for the environment to replace.

The only reason to keep it is because the object may not be the same as the one at the index. The one at the index is the one to use as "old", but it can be helpful to have the event.old as well, especially when debugging. So I'd like to keep it.

The only reason to keep it is because the object may not be the same as the one at the index

Maybe I don't understand your point, but we're using areSameEnvironments to look for matching environments, so we do not need to do exact object comparison to replace the one at the index. The only purpose for event.old was to search for the old environment which was fired and replace it.

Also, in the resolver, I found out that it's a bit hard to maintain the exact "old" environment to be used for firing in certain circumstances.

but it can be helpful to have the event.old as well, especially when debugging

Yaa maybe, although if that's the only reason I think we should remove it.

Is event.old only for debugging purposes?

Removing old would take some work, so I'm fine with keeping it for now. I was just curious about the above question^^

It could certainly be used for debugging. However, I can imagine it being used for other things too.

src/client/pythonEnvironments/base/locatorUtils.ts

src/test/pythonEnvironments/base/common.ts

src/client/pythonEnvironments/base/info/env.ts

src/test/pythonEnvironments/base/common.ts

src/client/pythonEnvironments/base/locator.ts

src/client/pythonEnvironments/base/locatorUtils.ts

karrtikr · 2020-09-25T14:23:57Z

src/client/pythonEnvironments/base/locator.ts

     */
-    old: PythonEnvInfo;
+    old?: PythonEnvInfo;


Is event.old only for debugging purposes?

src/client/pythonEnvironments/base/locatorUtils.ts

src/client/pythonEnvironments/base/info/env.ts

src/client/pythonEnvironments/base/locatorUtils.ts

…ooted cases.

sonarcloud · 2020-09-29T00:26:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public

* Add persistent storage external deps * PythonEnvInfoCache class + tests * Instantiate & initialize cache class in createAPI * Add extra test for flush() and initialize() * Env cache fixes: storage key + find() result check * Update src/client/pythonEnvironments/common/externalDependencies.ts Co-authored-by: Kartik Raj <karraj@microsoft.com> * Use areSameEnvironment in getEnv * Don't ping persistent storage for every initialize * No need to export CompleteEnvInfoFunction * PythonEnvInfoCache doc comment * Rename createGlobalPersistentStoreStub to get... * Preemptively drop id key (#14051) * Return deep copies * IPersistentStore wrapper around IPersistentState * Use correct areSameEnvironment + fix stub * Remove obsolete comment * getEnv -> filterEnvs * Remove stubbing of areSameEnvironment * Update areSameEnv * Move IPersistentStateFactory registration to registerForIOC * Revert "Move IPersistentStateFactory registration to registerForIOC" This reverts commit edc6ce5. * Don't instantiate nor initialize cache for now Co-authored-by: Kartik Raj <karraj@microsoft.com>

* Add an optional onUpdated event to the iterator returned by ILocator.iterEnvs(). (#13950) In order to ensure that ILocator.iterEnvs() can finish as fast as possible, we add a side-channel event for each iteration. This event fires any time an already-yielded env info object is updated (e.g. reduced/merged or resolved/completed). The update only relates to operations triggered by that particular iteration. ILocator.onChanged remains separate and only relates to when the locators finds a new env, notices one was removed, or that one was otherwise fundamentally changed. There are two similar approaches we could take for this update event. Either we added the event as a property of IPythonEnvsIterator or we change the return value of ILocator.iterEnvs() to be a 2-tuple ([PythonEnvsIterator, Event<PythonEnvUpdatedEvent>]). We took the property approach since most of the time callers won't need to worry about the update events. * fully bump raw kernel (#13941) Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> * Virtualenvwrapper locator (#13895) * virtualenvwrapper locator * skip os-specific tests * Test getDefaultVirtualenvwrapperDir * Update src/client/pythonEnvironments/discovery/locators/services/virtualenvwrapperLocator.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * add pathExists check to WORKON_HOME dir * Change how the locator works + move util func out * Fix functional tests * utils unit tests * Update locator tests * Stub getUserHomeDir instead of getDefaultetc Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Clean up eslint errors (#13951) * Clean up eslint errors * Fix linting and address comments. * Add a legacy DI adapter for the Python envs component. (#13858) This allows us to start using the new discovery code in the extension. * Extension api for DataScience (#13923) * Extension API * Api for DS * Fix installing ipykernel into interpreters for raw kernel (#13959) * Fix kernel and server name missing in certain situations (#13974) * Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry * Extension API to return path to debugpy for DS (#13973) * Use the component adapter in the extension. (#13869) This allows us to start using the new discovery code in the extension. The key thing is to be careful not to regress in the available functionality. So for now we have disabled use of the component. When we feel comfortable with it we can enable it by setting the default for `ComponentAdapter.enabled` to `true`. This PR involves small fixes to a large number of files due to API changes. The adapter is actually used (injected) in the following files: src/client/interpreter/interpreterService.ts src/client/interpreter/helpers.ts src/client/pythonEnvironments/discovery/locators/index.ts src/client/pythonEnvironments/discovery/locators/services/condaService.ts src/client/pythonEnvironments/discovery/locators/services/windowsStoreInterpreter.ts * Disable split views of custom editors (#13985) * Fix backup storage by looking at the options correctly (#13983) * Fix backup storage by looking at the options correctly * Fix backup by being more explicit * Only linux tests are failing. Hopefully fix them * update test plan for ipykernel (python repo) (#13993) * Find interpreter based on hash in kernelspec of nb metadata (#13856) * Pyenv locator (#13996) * Pyenv locator * Skip tests per platform * Wrong pyenv path order in ternary * Add description * Autoformat venv locator * Revert "Autoformat venv locator" This reverts commit 5c8c4ab. * Add links * Windows-specific fixes * Typo * merge * Revert "merge" This reverts commit ee0cad9. * Remove cwd while running using isolate script (#14014) * Remove cwd while running using isolate script * Run inplace. * Fix formatting * Upgrade isort to 5.5.3 (#14035) * Modify environment info worker to support new type and to work with resolver (#13997) * Modify environment info worker to support new environment type * Do not replace existing fields and return a new object * Modify cache to carry deferred instead * Change worker to return interpreter information instead * Handle error and rename * Fix bug with interpreterInfo.py * Code reviews * Rename old PythonEnvInfo type to InterpreterInfoJson * Remove cross process lock (#14036) * Add API to get language server from external extensions (#14021) * Ideas for lang server API with python extension * Working with new API * Minimize API surface * Fix up tests for intellisense * Fix unit tests * Put back custom editor service * Remove unnecessary changes for service registry * Code review feedback * Move connection type to types file * Fix failing virtualenvwrapper Windows unit tests (#14012) * Fix tests * Typo Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * make sure that we run our show code when a custom editor is shown (#14022) * make sure that we run our show code when a custom editor is shown * Trigger notebook load in the constructor, not show Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> * Rely on AppInsights API for exceptions (#13878) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Telemetry for exceptions * Remove custom exception telemetry * Remove unused * Fix HTML escaping to match what Jupyter does (#14038) * Basic idea * add some functional tests * Add news entry * Fix functional tests * Have dependabot ignore pytest and py (#14039) Otherwise it doesn't understand the Python 2.7 restrictions for those dependencies. * Added environments reducer (#13953) * Add environments reducer * Added tests * Use path.join to construct paths * Code reviews * Correct dummy implementations and adjust tests * Modify resolveEnv() * Rename to a general parentLocator * Merge release back to master (#14059) * Port ipykernel install fix to release (#13975) * Fix installing ipykernel into interpreters for raw kernel (#13959) * update news Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> * Merge in changes to release (#13976) * Up release version for new release (#13928) * Up release version * Update changelog * Update changelog * Workaround test issue (#13930) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * More tests failing with gpu error (#13935) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * Two more version changes * Fix kernel and server name missing in certain situations (#13974) * Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry * Delete news file * Port two fixes to the release branch (#13995) * Disable split views of custom editors (#13985) * Fix backup storage by looking at the options correctly (#13983) * Fix backup storage by looking at the options correctly * Fix backup by being more explicit * Only linux tests are failing. Hopefully fix them * Fixup changelog Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * add jedi-language-server to 3rd party notices (#13977) * add jedi-language-server to 3rd party notices * move license from distribution to repository file * disable test_discover_complex_default and (#14024) test_discover_complex_doctest * Upgrade isort to 5.5.3 (#14035) (#14037) * prepare release (#14042) * fixed annoying warnings (#14049) * update version Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> * Fix object sort order in tools tests (#14050) * Fix object sort order in tools tests * rebase with main * Fix formatting * Update ubuntu images for GPU issue fix (#14064) * Update ubuntu images for GPU issue fix * Try with ubuntu-20.04 * Added environments resolver (#14019) * Modify environment info worker to support new environment type * Change worker to return interpreter information instead * Modify resolveEnv() * Code reviews * Code reviews * Move stuff * Add Windows unit tests to the PR pipeline (#14106) * Do not opt users out of the insiders program if they have a stable version installed (#14091) * Remove code that opts users out of the insiders program * News entry * Code reviews * Do not quote isolated in exec module (#14108) * Do not quote isolated in exec module * Revert "Do not quote isolated in exec module" This reverts commit b9fa04c. * Revert "IPyKernel install issue with windows paths (#13667)" This reverts commit 23725ab. * Update cell output and metadata using Edit API (#13737) * Fix unit test broken by recent revert (#14122) * revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes (#14109) * revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes * Revert "revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes" This reverts commit 6ed8f61. * Remove force 1.48 on Test VSC channel * Merge environment and compare environments (#14026) * Add some heuristic functions * Support merging. * Clean up identifier code * Tweaks and fixes * More clean up. * versions tweak * Address comments * more comments * Fix merge issues. * Fix more merge issues. * Add PythonEnvInfo-related helpers. (#14051) This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public * Escaping fix broke a number of things (#14145) * Fixes for escaping * Push a comment ot start PR again * Cache task is failing * Remove cache task * Not fixing so just put back cache task * Auto assign datascience issues (#14147) * Change name of event used to activate extension (#14153) * Fixes to streamed output in native notebooks (#14158) For #13611 * Fixes to streamed output * added tests * Fixes to for escaping of output in native notebooks (#14159) * Look for `data science` labels when auto assigning issues (#14161) * Environment info cache class (#14065) * Add persistent storage external deps * PythonEnvInfoCache class + tests * Instantiate & initialize cache class in createAPI * Add extra test for flush() and initialize() * Env cache fixes: storage key + find() result check * Update src/client/pythonEnvironments/common/externalDependencies.ts Co-authored-by: Kartik Raj <karraj@microsoft.com> * Use areSameEnvironment in getEnv * Don't ping persistent storage for every initialize * No need to export CompleteEnvInfoFunction * PythonEnvInfoCache doc comment * Rename createGlobalPersistentStoreStub to get... * Preemptively drop id key (#14051) * Return deep copies * IPersistentStore wrapper around IPersistentState * Use correct areSameEnvironment + fix stub * Remove obsolete comment * getEnv -> filterEnvs * Remove stubbing of areSameEnvironment * Update areSameEnv * Move IPersistentStateFactory registration to registerForIOC * Revert "Move IPersistentStateFactory registration to registerForIOC" This reverts commit edc6ce5. * Don't instantiate nor initialize cache for now Co-authored-by: Kartik Raj <karraj@microsoft.com> * Update Component Governance notes in the release plan * Merge point release back into main (#14171) * Port ipykernel install fix to release (#13975) * Fix installing ipykernel into interpreters for raw kernel (#13959) * update news Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> * Merge in changes to release (#13976) * Up release version for new release (#13928) * Up release version * Update changelog * Update changelog * Workaround test issue (#13930) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * More tests failing with gpu error (#13935) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * Two more version changes * Fix kernel and server name missing in certain situations (#13974) * Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry * Delete news file * Port two fixes to the release branch (#13995) * Disable split views of custom editors (#13985) * Fix backup storage by looking at the options correctly (#13983) * Fix backup storage by looking at the options correctly * Fix backup by being more explicit * Only linux tests are failing. Hopefully fix them * Fixup changelog Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * add jedi-language-server to 3rd party notices (#13977) * add jedi-language-server to 3rd party notices * move license from distribution to repository file * disable test_discover_complex_default and (#14024) test_discover_complex_doctest * Upgrade isort to 5.5.3 (#14035) (#14037) * prepare release (#14042) * fixed annoying warnings (#14049) * Cherry pick to address path issues. (#14125) * Do not quote isolated in exec module (#14108) * Do not quote isolated in exec module * Revert "Do not quote isolated in exec module" This reverts commit b9fa04c. * Revert "IPyKernel install issue with windows paths (#13667)" This reverts commit 23725ab. * Fix unit test broken by recent revert (#14122) * Port escape fix to release branch (#14133) * Fix HTML escaping to match what Jupyter does (#14038) * Basic idea * add some functional tests * Add news entry * Fix functional tests * Update changelog * update version and changelog (#14139) * Escaping fix broke a number of things (#14145) (#14154) * Fixes for escaping * Push a comment ot start PR again * Cache task is failing * Remove cache task * Not fixing so just put back cache task * remove leftovers * import pytest * stop skipping python tests Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * NB Convert 6.0 support for export (#14177) * Windows store locator (#14162) * Initial commit for windows store locator * More tests * Simplify locator * Tweaks * Test fixes * Fix tests * A different way of fixing escaping (#14186) * Move escaping to just output * Add some tests to verify round tripping * Fixup test for rountrip and make roundtripping actually work * Add news entry * Add to manual test file * Fix streaming problem and add more to the test * Fix traceback unit test * Fix problem caught by functional tests :) * Another functional test catch * Fixes to escaping of output in native notebooks (#14199) * Display description in kernel picker (#14196) * Bump node-fetch to 2.6.1 (#14181) * Bump pytest from 6.0.1 to 6.1.0 in /news (#14190) Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.0.1 to 6.1.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.0.1...6.1.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Messed up merge commits Co-authored-by: Eric Snow <eric.snow@microsoft.com> Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Graham Wheeler <gram@geekraver.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: David Kutugata <dakutuga@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public

* Add PythonEnvInfo-related helpers. (#14051) This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public * Undo unintentional formatting changes * And? * Fix missing default * Fix linting Co-authored-by: Eric Snow <eric.snow@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

…soft#14152) * Add PythonEnvInfo-related helpers. (microsoft#14051) This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public * Undo unintentional formatting changes * And? * Fix missing default * Fix linting Co-authored-by: Eric Snow <eric.snow@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

ericsnowcurrently added the no-changelog No news entry required label Sep 23, 2020

ericsnowcurrently requested review from karthiknadig and karrtikr September 23, 2020 03:28

ericsnowcurrently mentioned this pull request Sep 23, 2020

Add CachingLocator. #14020

Merged

5 tasks

This was referenced Sep 23, 2020

Merge environment and compare environments #14026

Merged

Added environments reducer #13953

Merged

Added environments resolver #14019

Merged

karrtikr reviewed Sep 23, 2020

View reviewed changes

karthiknadig reviewed Sep 23, 2020

View reviewed changes

src/client/pythonEnvironments/base/info/env.ts Show resolved Hide resolved

src/test/pythonEnvironments/base/common.ts Outdated Show resolved Hide resolved

ericsnowcurrently mentioned this pull request Sep 24, 2020

Environment info cache class #14065

Merged

10 tasks

ericsnowcurrently requested review from karthiknadig and karrtikr September 24, 2020 22:16

karrtikr reviewed Sep 25, 2020

View reviewed changes

kimadeline added a commit to kimadeline/vscode-python that referenced this pull request Sep 25, 2020

Preemptively drop id key (microsoft#14051)

93075c0

karthiknadig reviewed Sep 25, 2020

View reviewed changes

src/client/pythonEnvironments/base/info/env.ts Show resolved Hide resolved

ericsnowcurrently force-pushed the pyenvs-component-helpers-1 branch from 5847336 to 364e793 Compare September 28, 2020 19:25

ericsnowcurrently requested review from karthiknadig and karrtikr September 28, 2020 19:38

karrtikr reviewed Sep 28, 2020

View reviewed changes

ericsnowcurrently added 10 commits September 28, 2020 14:10

Drop PythonEnvInfo.id.

1126834

Make buildEmptyEnvInfo() a public helper.

0d22681

Add a copyEnvInfo() helper.

4468e74

Add locator utils.

94137c8

Use getEnvs() in ComponentAdapter.getInterpreters().

eea499b

Add PythonEnvUpdatedEvent.index.

7a2fdfc

Fix reducer and resolver.

ca2ec73

Make parseVersion() a public helper.

af6c7c5

buildEmptyEnvInfo() -> buildEnvInfo().

e737607

Factor out updateEnv().

51c6dee

ericsnowcurrently added 12 commits September 28, 2020 14:27

Use lodash.cloneDeep() to deep-copy objects.

2ecd537

Drop the testing helper createEnv().

9cd6c7d

Factor out getURIFilter().

6b50973

Allow locator queries to mix search locations and non.

ad8f195

Match subdirectories in locator queries.

2b70a1c

Make PythonVersion.release optional.

7b19538

Drop the fixPath() testing helper.

eb746f9

lint

20c46da

Clarify what a missing query field means.

9d970f5

Make PythonLocatorQuery.searchLocations more explicit about the non-r…

ce53e54

…ooted cases.

Fix a sonarcloud warning.

3d85fa7

Filter out undefined locations in the tests.

e47322b

ericsnowcurrently force-pushed the pyenvs-component-helpers-1 branch from 9d9acdf to e47322b Compare September 28, 2020 20:38

Simplify the searchLocations logic a little.

f97bb31

karthiknadig approved these changes Sep 28, 2020

View reviewed changes

ericsnowcurrently added 2 commits September 28, 2020 15:25

Strip trailing slashes in paths.

1edb76d

Add getMinimalPartialInfo().

fd5e37b

ericsnowcurrently merged commit 218dd8d into microsoft:main Sep 29, 2020

ericsnowcurrently deleted the pyenvs-component-helpers-1 branch September 29, 2020 01:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PythonEnvInfo-related helpers. #14051

Add PythonEnvInfo-related helpers. #14051

ericsnowcurrently commented Sep 23, 2020 •

edited

Loading

codecov-commenter commented Sep 23, 2020 •

edited

Loading

karrtikr Sep 23, 2020 •

edited by ericsnowcurrently

Loading

ericsnowcurrently Sep 23, 2020

karrtikr Sep 23, 2020

karrtikr Sep 25, 2020

karrtikr Sep 28, 2020

ericsnowcurrently Sep 28, 2020

karrtikr Sep 25, 2020

sonarcloud bot commented Sep 29, 2020

Add PythonEnvInfo-related helpers. #14051

Add PythonEnvInfo-related helpers. #14051

Conversation

ericsnowcurrently commented Sep 23, 2020 • edited Loading

codecov-commenter commented Sep 23, 2020 • edited Loading

Codecov Report

karrtikr Sep 23, 2020 • edited by ericsnowcurrently Loading

Choose a reason for hiding this comment

ericsnowcurrently Sep 23, 2020

Choose a reason for hiding this comment

karrtikr Sep 23, 2020

Choose a reason for hiding this comment

karrtikr Sep 25, 2020

Choose a reason for hiding this comment

karrtikr Sep 28, 2020

Choose a reason for hiding this comment

ericsnowcurrently Sep 28, 2020

Choose a reason for hiding this comment

karrtikr Sep 25, 2020

Choose a reason for hiding this comment

sonarcloud bot commented Sep 29, 2020

ericsnowcurrently commented Sep 23, 2020 •

edited

Loading

codecov-commenter commented Sep 23, 2020 •

edited

Loading

karrtikr Sep 23, 2020 •

edited by ericsnowcurrently

Loading