Modify environment info worker to support new type and to work with resolver

[karrtikr]

Changing environment info worker to:

• Use the new environment type
• Accept the whole "environment" as input instead of just the path. This is because it would overwrite certain existing fields like version which are returned by running interpreter info and are reliable, but others fields should remain intact. Right now it's returning empty fields like this which aren't useful.
• Return new interpreter information type instead which is a subset of new environment type. Environment info service only informs about fields related to running interpreterInfo.py. It should have no business modifying other fields, that's the job of the consumer, in this case the resolver.
• Modified cache to carry deferred instead. If a previous call for the same environment path is already ongoing, we don't need add this environment to the worker pool but simply return the result from the previous call. This is a practical scenario the resolver runs into.

[codecov-commenter]

Codecov Report

Merging #13997 into main will decrease coverage by 0.04%.
The diff coverage is 45.90%.

@@            Coverage Diff             @@
##             main   #13997      +/-   ##
==========================================
- Coverage   59.75%   59.70%   -0.05%     
==========================================
  Files         697      700       +3     
  Lines       38650    38734      +84     
  Branches     5580     5600      +20     
==========================================
+ Hits        23096    23128      +32     
- Misses      14364    14401      +37     
- Partials     1190     1205      +15     

Impacted Files	Coverage Δ
src/client/common/process/pythonDaemon.ts	14.28% <0.00%> (ø)
...client/pythonEnvironments/base/info/interpreter.ts	23.80% <23.80%> (ø)
.../pythonEnvironments/info/environmentInfoService.ts	43.75% <28.57%> (-6.25%)	⬇️
...ient/pythonEnvironments/base/info/pythonVersion.ts	71.42% <71.42%> (ø)
...rc/client/common/process/internal/scripts/index.ts	70.12% <100.00%> (ø)
src/client/pythonEnvironments/info/interpreter.ts	80.95% <100.00%> (ø)
src/client/common/utils/platform.ts	60.00% <0.00%> (-12.00%)	⬇️
src/client/datascience/crossProcessLock.ts	79.41% <0.00%> (-11.77%)	⬇️
...very/locators/services/virtualenvwrapperLocator.ts	81.81% <0.00%> (-9.10%)	⬇️
...pythonEnvironments/common/environmentIdentifier.ts	91.66% <0.00%> (-8.34%)	⬇️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b8965...b5ce54a. Read the comment docs.

[karrtikr]

Most of it is copied from src\client\pythonEnvironments\info\interpreter.ts which is to be removed later. All the new types are being put inside base folder.

[karrtikr]

The JSON expected in the code contains sysVersion field.

vscode-python/src/client/common/process/internal/scripts/index.ts

Lines 44 to 63 in 23725ab

	export type PythonEnvInfo = {
	versionInfo: PythonVersionInfo;
	sysPrefix: string;
	sysVersion: string;
	is64Bit: boolean;
	};
	export function interpreterInfo(): [string[], (out: string) => PythonEnvInfo] {
	const script = path.join(SCRIPTS_DIR, 'interpreterInfo.py');
	const args = [ISOLATED, script];
	function parse(out: string): PythonEnvInfo {
	let json: PythonEnvInfo;
	try {
	json = JSON.parse(out);
	} catch (ex) {
	throw Error(`python ${args} returned bad JSON (${out}) (${ex})`);
	}
	return json;
	}

This bug existed since 3 years ago lol, when we first added interpreterInfo.py.

[kimadeline]

How come it hadn't been caught until now, we never needed this field?

[karrtikr]

Looks like we actually don't. I'll create a separate issue to remove it.

[kimadeline]

Why is sonarcloud upset?

[kimadeline]

How come it hadn't been caught until now, we never needed this field?

[karrtikr]

@kimadeline It's because of the duplication I mentioned #13997 (comment). We plan to get rid of the old code later so this isn't a problem.

[kimadeline]

There's already an InterpreterInformation type being exported from src/client/pythonEnvironments/info/index.ts. I think it would be more clear if this type had a different name to minimize future auto-import mix-ups.

Not part of this PR, but we also have multiple PythonEnvInfo types, so.... 😕

Up to you.

[karrtikr]

We'll be getting rid of the old InterpreterInformation type, and I didn't want to choose a new name because InterpreterInformation is the most correct name I can think of.

I'll take care of the PythonEnvInfo type.

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
3.3% Duplication