Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic to validate ComSpec #20927

Merged
merged 9 commits into from
Mar 29, 2023
Merged

Add diagnostic to validate ComSpec #20927

merged 9 commits into from
Mar 29, 2023

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Mar 28, 2023

Closes #16692

@karrtikr karrtikr added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Mar 28, 2023
@karrtikr karrtikr marked this pull request as ready for review March 28, 2023 23:18
@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Mar 28, 2023
Comment on lines 46 to 53
'We detected an issue with one of your environment variables that breaks features such as IntelliSense, linting and debugging. Try setting the "ComSpec" variable to a valid Command Prompt path in your system to fix it.',
),
[DiagnosticCodes.IncompletePathVarDiagnostic]: l10n.t(
'We detected an issue with "Path" environment variable that breaks features such as IntelliSense, linting and debugging. Please edit it to make sure it contains the "SystemRoot" subdirectories.',
),
[DiagnosticCodes.DefaultShellErrorDiagnostic]: l10n.t(
'We detected an issue with your default shell that breaks features such as IntelliSense, linting and debugging. Try resetting "Comspec" and "Path" environment variables to fix it.',
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luabud @cwebster-99 Need input from you on these texts.

Try resetting "Comspec" and "Path" environment variables to fix it.

That seems like one of those thing that requires more info. We could create a troubleshooting wiki page and point all users to that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea of adding a wiki page!

Copy link
Author

@karrtikr karrtikr Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like one of those thing that requires more info.

Note there's a "See instructions" button containing more troubleshooting info. But I agree a wiki page is probably better than linking to comments.

Comment on lines +272 to +274
InvalidComspecDiagnostic: 'https://aka.ms/AAk3djo',
IncompletePathVarDiagnostic: 'https://aka.ms/AAk744c',
DefaultShellErrorDiagnostic: 'https://aka.ms/AAk7qix',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add info to wiki page. I am a bit worried about issues getting moved and comments getting lost,

What do you think? @luabud @cwebster-99

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to wiki page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this is aka.ms link, I don't think the PR should be blocked on the wiki page being created.
And let me know if you'd like help with the wiki page!

Copy link
Author

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig Thanks, will create a wiki page and edit those aka.ms links! Although as @luabud pointed out it doesn't have to block the PR.

await this.shellExecPython();
} catch (ex) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
if ((ex as any).errno === -4058) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we only show these diagnostics if a very particular error code is observed.

@karrtikr karrtikr merged commit b208384 into microsoft:main Mar 29, 2023
@karrtikr karrtikr deleted the comspec branch March 29, 2023 00:02
@karrtikr
Copy link
Author

FYI I have a created a troubleshooting wiki: https://github.com/microsoft/vscode-python/wiki/Troubleshoot-'-4058-ENOENT'-error-from-NodeJS

Feel free to edit it as you deem fit !

karrtikr pushed a commit that referenced this pull request Mar 29, 2023
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Merge pull request #58 from posit-dev/merge-latest

Merge latest upstream
--------------------
Commit message for posit-dev/positron-python@b5cbe4f:

Merge latest upstream

--------------------
Commit message for microsoft/vscode-python@96aa8f8:

Do not deprecate `python.terminal.activateEnvironmentInTerminal` setting along with terminal env var experiment (microsoft/vscode-python#20952)

I initially deprecated this setting as I thought folks only disabled it
because we were sending commands which was annoying.
--------------------
Commit message for microsoft/vscode-python@37a70fd:

Update note on the Jupyter extension in README (microsoft/vscode-python#20946)

Karthik brought this up offline and I agree, instead of saying we don't
offer support out of box, we say it needs to be via the Jupyter
extension.
--------------------
Commit message for microsoft/vscode-python@bc59a7d:

Fix linting in APIs (microsoft/vscode-python#20623)

Fix lint in api.ts
--------------------
Commit message for microsoft/vscode-python@34c54f4:

No longer install the Jupyter extension by default (microsoft/vscode-python#20218)

For microsoft/vscode-python#18073

---------

Co-authored-by: Brett Cannon <brett@python.org>
--------------------
Commit message for microsoft/vscode-python@8d8784f:

Fix diagnostic to use "System32" instead of "SystemRoot" (microsoft/vscode-python#20937)

For microsoft/vscode-python#16692
Follow up to microsoft/vscode-python#20927
--------------------
Commit message for microsoft/vscode-python@ef6511e:

Fix telemetry when updating pip (microsoft/vscode-python#20903)

@luabud This PR adds a minor telemetry change to create environment.
There is a new telemetry point indicating pip upgrade.
--------------------
Commit message for microsoft/vscode-python@b208384:

Add diagnostic to validate ComSpec (microsoft/vscode-python#20927)

Closes microsoft/vscode-python#16692
--------------------
Commit message for microsoft/vscode-python@5fd9f97:

Update main to next pre-release (microsoft/vscode-python#20928)


--------------------
Commit message for microsoft/vscode-python@6e31c6a:

Update version of main to release candidate (microsoft/vscode-python#20923)


--------------------
Commit message for microsoft/vscode-python@d809af4:

Use new formatter install prompt on missing formatter (microsoft/vscode-python#20904)


--------------------
Commit message for microsoft/vscode-python@43a21a2:

Remove HTTP Client usage (microsoft/vscode-python#20922)

This is addressing an internal CG issue.
--------------------
Commit message for microsoft/vscode-python@5f9be4e:

Make sure we delay start pylance server (microsoft/vscode-python#20910)

fixes microsoft/vscode-python#20909

Activating `pylance` extension inside of `python` extension cause a dead
lock since they have circular dependency. now we make sure we activate
`pylance` once `python` extension is activated.

`node` already works this way. it is just browser extension that started
`pylance` inside `activate` directly.
--------------------
Commit message for microsoft/vscode-python@be55c97:

Adjust a few strings that mention Python (microsoft/vscode-python#20900)

For microsoft/vscode-python#20899 (+ a few
other strings I thought could use some tweaking too)
--------------------
Commit message for microsoft/vscode-python@61f93c3:

Fix title and placeholder for python selection when using create env command (microsoft/vscode-python#20896)

Closes microsoft/vscode-python#19891


![image](https://user-images.githubusercontent.com/3840081/227031948-de595993-80e1-43a0-8dd8-658848c6b3d5.png)
--------------------
Commit message for microsoft/vscode-python@01e798a:

Share telemetry from core extension. (microsoft/vscode-python#20893)

it turns out the new telemetry API removed a way to set extension id and
version when telemetry reporter is created and it implicitly sets from
extension reporter is created. the same way how LSP client is working.

since we want to keep using the same extension id and etc for our
telemetry, we need the reporter created from core ext.
--------------------
Commit message for microsoft/vscode-python@807b9fe:

Add create environment button to `requirements.txt` and `pyproject.toml` files (microsoft/vscode-python#20879)

Closes microsoft/vscode-python#20812
Related microsoft/vscode-python#20133
--------------------
Commit message for microsoft/vscode-python@730df28:

Add GDPR tag to new telemetry property (microsoft/vscode-python#20871)


--------------------
Commit message for microsoft/vscode-python@a6ac385:

Bump webpack from 5.70.0 to 5.76.0 (microsoft/vscode-python#20856)

Bumps [webpack](https://github.com/webpack/webpack) from 5.70.0 to
5.76.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/webpack/webpack/releases">webpack's
releases</a>.</em></p>
<blockquote>
<h2>v5.76.0</h2>
<h2>Bugfixes</h2>
<ul>
<li>Avoid cross-realm object access by <a
href="https://github.com/Jack-Works"><code>@​Jack-Works</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16500">webpack/webpack#16500</a></li>
<li>Improve hash performance via conditional initialization by <a
href="https://github.com/lvivski"><code>@​lvivski</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16491">webpack/webpack#16491</a></li>
<li>Serialize <code>generatedCode</code> info to fix bug in asset module
cache restoration by <a
href="https://github.com/ryanwilsonperkin"><code>@​ryanwilsonperkin</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16703">webpack/webpack#16703</a></li>
<li>Improve performance of <code>hashRegExp</code> lookup by <a
href="https://github.com/ryanwilsonperkin"><code>@​ryanwilsonperkin</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16759">webpack/webpack#16759</a></li>
</ul>
<h2>Features</h2>
<ul>
<li>add <code>target</code> to <code>LoaderContext</code> type by <a
href="https://github.com/askoufis"><code>@​askoufis</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16781">webpack/webpack#16781</a></li>
</ul>
<h2>Security</h2>
<ul>
<li><a
href="https://github.com/advisories/GHSA-3rfm-jhwj-7488">CVE-2022-37603</a>
fixed by <a
href="https://github.com/akhilgkrishnan"><code>@​akhilgkrishnan</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16446">webpack/webpack#16446</a></li>
</ul>
<h2>Repo Changes</h2>
<ul>
<li>Fix HTML5 logo in README by <a
href="https://github.com/jakebailey"><code>@​jakebailey</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16614">webpack/webpack#16614</a></li>
<li>Replace TypeScript logo in README by <a
href="https://github.com/jakebailey"><code>@​jakebailey</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16613">webpack/webpack#16613</a></li>
<li>Update actions/cache dependencies by <a
href="https://github.com/piwysocki"><code>@​piwysocki</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16493">webpack/webpack#16493</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/Jack-Works"><code>@​Jack-Works</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16500">webpack/webpack#16500</a></li>
<li><a href="https://github.com/lvivski"><code>@​lvivski</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16491">webpack/webpack#16491</a></li>
<li><a
href="https://github.com/jakebailey"><code>@​jakebailey</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16614">webpack/webpack#16614</a></li>
<li><a
href="https://github.com/akhilgkrishnan"><code>@​akhilgkrishnan</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16446">webpack/webpack#16446</a></li>
<li><a
href="https://github.com/ryanwilsonperkin"><code>@​ryanwilsonperkin</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16703">webpack/webpack#16703</a></li>
<li><a href="https://github.com/piwysocki"><code>@​piwysocki</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16493">webpack/webpack#16493</a></li>
<li><a href="https://github.com/askoufis"><code>@​askoufis</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16781">webpack/webpack#16781</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0">https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0</a></p>
<h2>v5.75.0</h2>
<h1>Bugfixes</h1>
<ul>
<li><code>experiments.*</code> normalize to <code>false</code> when
opt-out</li>
<li>avoid <code>NaN%</code></li>
<li>show the correct error when using a conflicting chunk name in
code</li>
<li>HMR code tests existance of <code>window</code> before trying to
access it</li>
<li>fix <code>eval-nosources-*</code> actually exclude sources</li>
<li>fix race condition where no module is returned from processing
module</li>
<li>fix position of standalong semicolon in runtime code</li>
</ul>
<h1>Features</h1>
<ul>
<li>add support for <code>@import</code> to extenal CSS when using
experimental CSS in node</li>
<li>add <code>i64</code> support to the deprecated WASM
implementation</li>
</ul>
<h1>Developer Experience</h1>
<ul>
<li>expose <code>EnableWasmLoadingPlugin</code></li>
<li>add more typings</li>
<li>generate getters instead of readonly properties in typings to allow
overriding them</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/webpack/webpack/commit/97b1718720c33f1b17302a74c5284b01e02ec001"><code>97b1718</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16781">#16781</a>
from askoufis/loader-context-target-type</li>
<li><a
href="https://github.com/webpack/webpack/commit/b84efe6224b276bf72e4c5e2f4e76acddfaeef07"><code>b84efe6</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16759">#16759</a>
from ryanwilsonperkin/real-content-hash-regex-perf</li>
<li><a
href="https://github.com/webpack/webpack/commit/c98e9e001441b165c7ed4845700839730b505833"><code>c98e9e0</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16493">#16493</a>
from piwysocki/patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/5f34acfbc074da6cc09f48944d7f2b4273ffb3f8"><code>5f34acf</code></a>
feat: Add <code>target</code> to <code>LoaderContext</code> type</li>
<li><a
href="https://github.com/webpack/webpack/commit/b7fc4d876deb958d7ee81ecc00a312e39a354a44"><code>b7fc4d8</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16703">#16703</a>
from ryanwilsonperkin/ryanwilsonperkin/fix-16160</li>
<li><a
href="https://github.com/webpack/webpack/commit/63ea82da4d4e4242b6a6285fc937f0684f264fe8"><code>63ea82d</code></a>
Merge branch 'webpack:main' into patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/4ba225225b1348c8776ca5b5fe53468519413bc0"><code>4ba2252</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16446">#16446</a>
from akhilgkrishnan/patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/1acd6350be3d74d4ac70b64cbbc60f27724b618b"><code>1acd635</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16613">#16613</a>
from jakebailey/ts-logo</li>
<li><a
href="https://github.com/webpack/webpack/commit/302eb37fe19ed7ca60eaf895aca4f9da9dfd7931"><code>302eb37</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16614">#16614</a>
from jakebailey/html5-logo</li>
<li><a
href="https://github.com/webpack/webpack/commit/cfdb1dfe59b33bf7441b8a8e4fc58d75e4f54cee"><code>cfdb1df</code></a>
Improve performance of hashRegExp lookup</li>
<li>Additional commits viewable in <a
href="https://github.com/webpack/webpack/compare/v5.70.0...v5.76.0">compare
view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a
href="https://www.npmjs.com/~evilebottnawi">evilebottnawi</a>, a new
releaser for webpack since your current version.</p>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=webpack&package-manager=npm_and_yarn&previous-version=5.70.0&new-version=5.76.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/microsoft/vscode-python/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@3269137:

Finalize Python Environment API (microsoft/vscode-python#20868)


--------------------
Commit message for microsoft/vscode-python@00ce6d0:

Update text shown in formatter install prompt (microsoft/vscode-python#20869)


--------------------
Commit message for microsoft/vscode-python@d16568e:

Ensure `resolveEnvironment` API resolves the latest details for conda envs without python (microsoft/vscode-python#20862)

Closes microsoft/vscode-python#20765

Change `resolveEnvironment` API to validate cache for conda envs without
python before using it, it also making sure we fire a update event after
resolving it and adding it to cache.
--------------------
Commit message for microsoft/vscode-python@7ee3f7d:

Show prompt asking user to install formatter extension (microsoft/vscode-python#20861)

For microsoft/vscode-python#19653
--------------------
Commit message for microsoft/vscode-python@b9c4ff7:

Update walkthrough title (microsoft/vscode-python#20857)

For consistency with other language extensions
--------------------
Commit message for microsoft/vscode-python@1668d06:

Made browser to expose pylance api. (microsoft/vscode-python#20847)

This will let pylance to create LS Client on browser
--------------------
Commit message for microsoft/vscode-python@0735876:

Share output channel with pylance (microsoft/vscode-python#20833)

Make sure `pylance` and `jedi` share the same output channel.
--------------------
Commit message for microsoft/vscode-python@2cd2092:

Fixed a bug where pylance not working on interactive window. (microsoft/vscode-python#20831)

https://github.com/microsoft/vscode-python/pull/20816/files#diff-ba59d9ca0a087381d63119a88751fdc7c0aa07e6a10e772d3aefd4c10aa36fcfL47

this should have changed to return `false` rather than deleting since it
would have been always return `false`. deleting effectively made it to
have the same effect as always returning `true`

follow up PR of microsoft/vscode-python#20816
--------------------
Commit message for microsoft/vscode-python@d3dd832:

Expose client creation API for pylance (microsoft/vscode-python#20816)

If new client change is available in pylance, made core extension to use
pylance to do language server lifetime management. and also this PR
removes all old notebook experiences so that it is inline with pylance
(pylance already removed all those when moving client/middleware)
--------------------
Commit message for microsoft/vscode-python@b897300:

Restart reason telemetry event for `pylance` (microsoft/vscode-python#20821)

Closes microsoft/vscode-python#19626
--------------------
Commit message for microsoft/vscode-python@8a80ebe:

Add experiment to implicitly use environment variables for environment activation (microsoft/vscode-python#20651)


--------------------
Commit message for microsoft/vscode-python@7aac96a:

Fix typo with `clientOS` (microsoft/vscode-python#20819)


--------------------
Commit message for microsoft/vscode-python@e9ff78d:

Set clientOS debug option (microsoft/vscode-python#20805)

Closed: microsoft/vscode-python#20407
--------------------
Commit message for microsoft/vscode-python@467823d:

Add option to control if environment is selected after creation (microsoft/vscode-python#20738)

For: microsoft/vscode-python#20270

@DonJayamanne This PR adds a field to the options that should allow you
to skip environment selection.
--------------------
Commit message for microsoft/vscode-python@672d07e:

Do not use `-I` flag in case we're unable to find `encodings` module when validating python (microsoft/vscode-python#20803)

Closes microsoft/vscode-python#20793
--------------------
Commit message for microsoft/vscode-python@2442dfb:

Add logging which could help indicate why `Discovering Python Interpreters...` never finishes (microsoft/vscode-python#20792)

For microsoft/vscode-python#20250
--------------------
Commit message for microsoft/vscode-python@e8303bb:

Fix ability to recognize extensions which access environment API (microsoft/vscode-python#20791)

Follow up from microsoft/vscode-python#20222.

Apparently `setTimeout` changed the stack in such a way that we were
unable to recognize which extension called the API:
```
[DEBUG 2023-2-2 16:21:9.641]: Extension unknown accessed getActiveEnvironmentPath with args: undefined
```
Reverting the change.
--------------------
Commit message for microsoft/vscode-python@ee8e80e:

Improve getting started experience when starting on a fresh macOS (microsoft/vscode-python#20789)

Closes microsoft/vscode-python#20635

- Suggest to install from `python.org` if brew is not available
- Do not suggest irrelevant prompts
--------------------
Commit message for microsoft/vscode-python@16c0437:

Update description of `python.terminal.activateEnvironment` setting (microsoft/vscode-python#20788)


--------------------
Commit message for microsoft/vscode-python@54e37fe:

Update README.md for isort changes (microsoft/vscode-python#20787)

Updating the README to reflect isort not being installed by default
--------------------
Commit message for microsoft/vscode-python@32c10e4:

Add verbose logging for change events fired related to envs (microsoft/vscode-python#20780)

For microsoft/vscode-python#20292
--------------------
Commit message for microsoft/vscode-python@be75eb2:

Ensure both `python` and `pythonPath` are not set when resolving config. (microsoft/vscode-python#20781)

Fixes microsoft/vscode-python#20655
--------------------
Commit message for microsoft/vscode-python@a5005f6:

Ensure picker returns array only if multi-select is enabled (microsoft/vscode-python#20772)

Fixes microsoft/vscode-python#20768
--------------------
Commit message for microsoft/vscode-python@c5e6378:

Update main to next pre-release (microsoft/vscode-python#20764)


--------------------
Commit message for microsoft/vscode-python@7c31a5e:

Updating version for release candidate. (microsoft/vscode-python#20762)


--------------------
Commit message for microsoft/vscode-python@e624eff:

Make sure conda activate is used for micromamba (microsoft/vscode-python#20760)

Closes microsoft/vscode-python#20756
--------------------
Commit message for microsoft/vscode-python@29bee00:

Fix debugger attach to process when running on WSL (microsoft/vscode-python#20741)

Possible fix for microsoft/vscode-python#16921

Closes microsoft/vscode-python#16921

BTW you folks should probably ask GitHub support to eject this repo from
their original repository (so it stops being a fork and has its own
network on GH)
--------------------
Commit message for microsoft/vscode-python@e9dba6c:

Bump typing-extensions from 4.4.0 to 4.5.0 (microsoft/vscode-python#20704)

Bumps [typing-extensions](https://github.com/python/typing_extensions)
from 4.4.0 to 4.5.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/python/typing_extensions/blob/main/CHANGELOG.md">typing-extensions's
changelog</a>.</em></p>
<blockquote>
<h1>Release 4.5.0 (February 14, 2023)</h1>
<ul>
<li>Runtime support for PEP 702, adding
<code>typing_extensions.deprecated</code>. Patch
by Jelle Zijlstra.</li>
<li>Add better default value for TypeVar <code>default</code> parameter,
PEP 696. Enables
runtime check if <code>None</code> was passed as default. Patch by Marc
Mueller (<a
href="https://github.com/cdce8p"><code>@​cdce8p</code></a>).</li>
<li>The <code>@typing_extensions.override</code> decorator now sets the
<code>.__override__</code>
attribute. Patch by Steven Troxler.</li>
<li>Fix <code>get_type_hints()</code> on cross-module inherited
<code>TypedDict</code> in 3.9 and 3.10.
Patch by Carl Meyer.</li>
<li>Add <code>frozen_default</code> parameter on
<code>dataclass_transform</code>. Patch by Erik De Bonte.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/python/typing_extensions/commit/8dcd89993c3926d6c704232b9c56160447fa81fe"><code>8dcd899</code></a>
Prepare release 4.5.0 (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/116">#116</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/e81cb8289874d6a6715675d77df88db033824e0d"><code>e81cb82</code></a>
PEP 702: Runtime warnings (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/112">#112</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/1039bb2730e62e9763b8fd1d6a19ddd6bb0b6fe4"><code>1039bb2</code></a>
fix PEP 702 link in the <code>README.md</code> (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/108">#108</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/673e5ceea32f77d90531d4d5e77a7694edba7fba"><code>673e5ce</code></a>
Add <a
href="https://github.com/typing"><code>@​typing</code></a>_extensions.deprecated
(<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/105">#105</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/27646ecba87fe518566db3d6b970574ad8df2490"><code>27646ec</code></a>
Fix tests on Python 3.11 (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/106">#106</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/57226b4fb64a5d9f4788e74fe3799d98fe02026b"><code>57226b4</code></a>
Add <code>frozen_default</code> parameter on
<code>dataclass_transform</code> (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/101">#101</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/0ea104bc37bd8f85246d48c7f6c7642f25771498"><code>0ea104b</code></a>
Expand the pyproject.toml sdist include expression to include
src/_typed_dict...</li>
<li><a
href="https://github.com/python/typing_extensions/commit/93ac93b58f23a2b7e4450cbe8819f5a36d319af7"><code>93ac93b</code></a>
CI: test on Ubuntu-20.04, not Ubuntu-2004 (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/100">#100</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/5f9258d1efd5d8e4900ffc23ba2486240f2a2f35"><code>5f9258d</code></a>
Test on Ubuntu 20.04</li>
<li><a
href="https://github.com/python/typing_extensions/commit/ad3966ddabe9adcbf2e76d88a7cf984fa9cb4237"><code>ad3966d</code></a>
Replace type comments with annotations (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/98">#98</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/python/typing_extensions/compare/4.4.0...4.5.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=typing-extensions&package-manager=pip&previous-version=4.4.0&new-version=4.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@35be3c2:

Ensure escape on TOML and requirements is treated as cancel. (microsoft/vscode-python#20739)


--------------------
Commit message for microsoft/vscode-python@5d9bc1e:

Tag Pylance settings properties for GDPR (microsoft/vscode-python#20745)


--------------------
Commit message for microsoft/vscode-python@70716f0:

Add description for `python.experiment` settings values (microsoft/vscode-python#20751)


--------------------
Commit message for microsoft/vscode-python@7b488a9:

Point to Python v3.11 instead of Python v3.10 when opening windows store (microsoft/vscode-python#20742)

Closes microsoft/vscode-python#20736

Lead-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
Co-authored-by: Jonathan Cardoso <me@jonathancardoso.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: paulacamargo25 <paulitacv25@gmail.com>
Co-authored-by: Pete Farland <pete.farland@posit.co>
Co-authored-by: Heejae Chang <1333179+heejaechang@users.noreply.github.com>
Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Signed-off-by: GitHub <noreply@github.com>
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Merge pull request #58 from posit-dev/merge-latest

Merge latest upstream
--------------------
Commit message for posit-dev/positron-python@b5cbe4f:

Merge latest upstream

--------------------
Commit message for microsoft/vscode-python@96aa8f8:

Do not deprecate `python.terminal.activateEnvironmentInTerminal` setting along with terminal env var experiment (microsoft/vscode-python#20952)

I initially deprecated this setting as I thought folks only disabled it
because we were sending commands which was annoying.
--------------------
Commit message for microsoft/vscode-python@37a70fd:

Update note on the Jupyter extension in README (microsoft/vscode-python#20946)

Karthik brought this up offline and I agree, instead of saying we don't
offer support out of box, we say it needs to be via the Jupyter
extension.
--------------------
Commit message for microsoft/vscode-python@bc59a7d:

Fix linting in APIs (microsoft/vscode-python#20623)

Fix lint in api.ts
--------------------
Commit message for microsoft/vscode-python@34c54f4:

No longer install the Jupyter extension by default (microsoft/vscode-python#20218)

For microsoft/vscode-python#18073

---------

Co-authored-by: Brett Cannon <brett@python.org>
--------------------
Commit message for microsoft/vscode-python@8d8784f:

Fix diagnostic to use "System32" instead of "SystemRoot" (microsoft/vscode-python#20937)

For microsoft/vscode-python#16692
Follow up to microsoft/vscode-python#20927
--------------------
Commit message for microsoft/vscode-python@ef6511e:

Fix telemetry when updating pip (microsoft/vscode-python#20903)

@luabud This PR adds a minor telemetry change to create environment.
There is a new telemetry point indicating pip upgrade.
--------------------
Commit message for microsoft/vscode-python@b208384:

Add diagnostic to validate ComSpec (microsoft/vscode-python#20927)

Closes microsoft/vscode-python#16692
--------------------
Commit message for microsoft/vscode-python@5fd9f97:

Update main to next pre-release (microsoft/vscode-python#20928)


--------------------
Commit message for microsoft/vscode-python@6e31c6a:

Update version of main to release candidate (microsoft/vscode-python#20923)


--------------------
Commit message for microsoft/vscode-python@d809af4:

Use new formatter install prompt on missing formatter (microsoft/vscode-python#20904)


--------------------
Commit message for microsoft/vscode-python@43a21a2:

Remove HTTP Client usage (microsoft/vscode-python#20922)

This is addressing an internal CG issue.
--------------------
Commit message for microsoft/vscode-python@5f9be4e:

Make sure we delay start pylance server (microsoft/vscode-python#20910)

fixes microsoft/vscode-python#20909

Activating `pylance` extension inside of `python` extension cause a dead
lock since they have circular dependency. now we make sure we activate
`pylance` once `python` extension is activated.

`node` already works this way. it is just browser extension that started
`pylance` inside `activate` directly.
--------------------
Commit message for microsoft/vscode-python@be55c97:

Adjust a few strings that mention Python (microsoft/vscode-python#20900)

For microsoft/vscode-python#20899 (+ a few
other strings I thought could use some tweaking too)
--------------------
Commit message for microsoft/vscode-python@61f93c3:

Fix title and placeholder for python selection when using create env command (microsoft/vscode-python#20896)

Closes microsoft/vscode-python#19891


![image](https://user-images.githubusercontent.com/3840081/227031948-de595993-80e1-43a0-8dd8-658848c6b3d5.png)
--------------------
Commit message for microsoft/vscode-python@01e798a:

Share telemetry from core extension. (microsoft/vscode-python#20893)

it turns out the new telemetry API removed a way to set extension id and
version when telemetry reporter is created and it implicitly sets from
extension reporter is created. the same way how LSP client is working.

since we want to keep using the same extension id and etc for our
telemetry, we need the reporter created from core ext.
--------------------
Commit message for microsoft/vscode-python@807b9fe:

Add create environment button to `requirements.txt` and `pyproject.toml` files (microsoft/vscode-python#20879)

Closes microsoft/vscode-python#20812
Related microsoft/vscode-python#20133
--------------------
Commit message for microsoft/vscode-python@730df28:

Add GDPR tag to new telemetry property (microsoft/vscode-python#20871)


--------------------
Commit message for microsoft/vscode-python@a6ac385:

Bump webpack from 5.70.0 to 5.76.0 (microsoft/vscode-python#20856)

Bumps [webpack](https://github.com/webpack/webpack) from 5.70.0 to
5.76.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/webpack/webpack/releases">webpack's
releases</a>.</em></p>
<blockquote>
<h2>v5.76.0</h2>
<h2>Bugfixes</h2>
<ul>
<li>Avoid cross-realm object access by <a
href="https://github.com/Jack-Works"><code>@​Jack-Works</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16500">webpack/webpack#16500</a></li>
<li>Improve hash performance via conditional initialization by <a
href="https://github.com/lvivski"><code>@​lvivski</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16491">webpack/webpack#16491</a></li>
<li>Serialize <code>generatedCode</code> info to fix bug in asset module
cache restoration by <a
href="https://github.com/ryanwilsonperkin"><code>@​ryanwilsonperkin</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16703">webpack/webpack#16703</a></li>
<li>Improve performance of <code>hashRegExp</code> lookup by <a
href="https://github.com/ryanwilsonperkin"><code>@​ryanwilsonperkin</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16759">webpack/webpack#16759</a></li>
</ul>
<h2>Features</h2>
<ul>
<li>add <code>target</code> to <code>LoaderContext</code> type by <a
href="https://github.com/askoufis"><code>@​askoufis</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16781">webpack/webpack#16781</a></li>
</ul>
<h2>Security</h2>
<ul>
<li><a
href="https://github.com/advisories/GHSA-3rfm-jhwj-7488">CVE-2022-37603</a>
fixed by <a
href="https://github.com/akhilgkrishnan"><code>@​akhilgkrishnan</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16446">webpack/webpack#16446</a></li>
</ul>
<h2>Repo Changes</h2>
<ul>
<li>Fix HTML5 logo in README by <a
href="https://github.com/jakebailey"><code>@​jakebailey</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16614">webpack/webpack#16614</a></li>
<li>Replace TypeScript logo in README by <a
href="https://github.com/jakebailey"><code>@​jakebailey</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16613">webpack/webpack#16613</a></li>
<li>Update actions/cache dependencies by <a
href="https://github.com/piwysocki"><code>@​piwysocki</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16493">webpack/webpack#16493</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/Jack-Works"><code>@​Jack-Works</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16500">webpack/webpack#16500</a></li>
<li><a href="https://github.com/lvivski"><code>@​lvivski</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16491">webpack/webpack#16491</a></li>
<li><a
href="https://github.com/jakebailey"><code>@​jakebailey</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16614">webpack/webpack#16614</a></li>
<li><a
href="https://github.com/akhilgkrishnan"><code>@​akhilgkrishnan</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16446">webpack/webpack#16446</a></li>
<li><a
href="https://github.com/ryanwilsonperkin"><code>@​ryanwilsonperkin</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16703">webpack/webpack#16703</a></li>
<li><a href="https://github.com/piwysocki"><code>@​piwysocki</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16493">webpack/webpack#16493</a></li>
<li><a href="https://github.com/askoufis"><code>@​askoufis</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16781">webpack/webpack#16781</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0">https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0</a></p>
<h2>v5.75.0</h2>
<h1>Bugfixes</h1>
<ul>
<li><code>experiments.*</code> normalize to <code>false</code> when
opt-out</li>
<li>avoid <code>NaN%</code></li>
<li>show the correct error when using a conflicting chunk name in
code</li>
<li>HMR code tests existance of <code>window</code> before trying to
access it</li>
<li>fix <code>eval-nosources-*</code> actually exclude sources</li>
<li>fix race condition where no module is returned from processing
module</li>
<li>fix position of standalong semicolon in runtime code</li>
</ul>
<h1>Features</h1>
<ul>
<li>add support for <code>@import</code> to extenal CSS when using
experimental CSS in node</li>
<li>add <code>i64</code> support to the deprecated WASM
implementation</li>
</ul>
<h1>Developer Experience</h1>
<ul>
<li>expose <code>EnableWasmLoadingPlugin</code></li>
<li>add more typings</li>
<li>generate getters instead of readonly properties in typings to allow
overriding them</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/webpack/webpack/commit/97b1718720c33f1b17302a74c5284b01e02ec001"><code>97b1718</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16781">#16781</a>
from askoufis/loader-context-target-type</li>
<li><a
href="https://github.com/webpack/webpack/commit/b84efe6224b276bf72e4c5e2f4e76acddfaeef07"><code>b84efe6</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16759">#16759</a>
from ryanwilsonperkin/real-content-hash-regex-perf</li>
<li><a
href="https://github.com/webpack/webpack/commit/c98e9e001441b165c7ed4845700839730b505833"><code>c98e9e0</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16493">#16493</a>
from piwysocki/patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/5f34acfbc074da6cc09f48944d7f2b4273ffb3f8"><code>5f34acf</code></a>
feat: Add <code>target</code> to <code>LoaderContext</code> type</li>
<li><a
href="https://github.com/webpack/webpack/commit/b7fc4d876deb958d7ee81ecc00a312e39a354a44"><code>b7fc4d8</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16703">#16703</a>
from ryanwilsonperkin/ryanwilsonperkin/fix-16160</li>
<li><a
href="https://github.com/webpack/webpack/commit/63ea82da4d4e4242b6a6285fc937f0684f264fe8"><code>63ea82d</code></a>
Merge branch 'webpack:main' into patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/4ba225225b1348c8776ca5b5fe53468519413bc0"><code>4ba2252</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16446">#16446</a>
from akhilgkrishnan/patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/1acd6350be3d74d4ac70b64cbbc60f27724b618b"><code>1acd635</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16613">#16613</a>
from jakebailey/ts-logo</li>
<li><a
href="https://github.com/webpack/webpack/commit/302eb37fe19ed7ca60eaf895aca4f9da9dfd7931"><code>302eb37</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16614">#16614</a>
from jakebailey/html5-logo</li>
<li><a
href="https://github.com/webpack/webpack/commit/cfdb1dfe59b33bf7441b8a8e4fc58d75e4f54cee"><code>cfdb1df</code></a>
Improve performance of hashRegExp lookup</li>
<li>Additional commits viewable in <a
href="https://github.com/webpack/webpack/compare/v5.70.0...v5.76.0">compare
view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a
href="https://www.npmjs.com/~evilebottnawi">evilebottnawi</a>, a new
releaser for webpack since your current version.</p>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=webpack&package-manager=npm_and_yarn&previous-version=5.70.0&new-version=5.76.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/microsoft/vscode-python/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@3269137:

Finalize Python Environment API (microsoft/vscode-python#20868)


--------------------
Commit message for microsoft/vscode-python@00ce6d0:

Update text shown in formatter install prompt (microsoft/vscode-python#20869)


--------------------
Commit message for microsoft/vscode-python@d16568e:

Ensure `resolveEnvironment` API resolves the latest details for conda envs without python (microsoft/vscode-python#20862)

Closes microsoft/vscode-python#20765

Change `resolveEnvironment` API to validate cache for conda envs without
python before using it, it also making sure we fire a update event after
resolving it and adding it to cache.
--------------------
Commit message for microsoft/vscode-python@7ee3f7d:

Show prompt asking user to install formatter extension (microsoft/vscode-python#20861)

For microsoft/vscode-python#19653
--------------------
Commit message for microsoft/vscode-python@b9c4ff7:

Update walkthrough title (microsoft/vscode-python#20857)

For consistency with other language extensions
--------------------
Commit message for microsoft/vscode-python@1668d06:

Made browser to expose pylance api. (microsoft/vscode-python#20847)

This will let pylance to create LS Client on browser
--------------------
Commit message for microsoft/vscode-python@0735876:

Share output channel with pylance (microsoft/vscode-python#20833)

Make sure `pylance` and `jedi` share the same output channel.
--------------------
Commit message for microsoft/vscode-python@2cd2092:

Fixed a bug where pylance not working on interactive window. (microsoft/vscode-python#20831)

https://github.com/microsoft/vscode-python/pull/20816/files#diff-ba59d9ca0a087381d63119a88751fdc7c0aa07e6a10e772d3aefd4c10aa36fcfL47

this should have changed to return `false` rather than deleting since it
would have been always return `false`. deleting effectively made it to
have the same effect as always returning `true`

follow up PR of microsoft/vscode-python#20816
--------------------
Commit message for microsoft/vscode-python@d3dd832:

Expose client creation API for pylance (microsoft/vscode-python#20816)

If new client change is available in pylance, made core extension to use
pylance to do language server lifetime management. and also this PR
removes all old notebook experiences so that it is inline with pylance
(pylance already removed all those when moving client/middleware)
--------------------
Commit message for microsoft/vscode-python@b897300:

Restart reason telemetry event for `pylance` (microsoft/vscode-python#20821)

Closes microsoft/vscode-python#19626
--------------------
Commit message for microsoft/vscode-python@8a80ebe:

Add experiment to implicitly use environment variables for environment activation (microsoft/vscode-python#20651)


--------------------
Commit message for microsoft/vscode-python@7aac96a:

Fix typo with `clientOS` (microsoft/vscode-python#20819)


--------------------
Commit message for microsoft/vscode-python@e9ff78d:

Set clientOS debug option (microsoft/vscode-python#20805)

Closed: microsoft/vscode-python#20407
--------------------
Commit message for microsoft/vscode-python@467823d:

Add option to control if environment is selected after creation (microsoft/vscode-python#20738)

For: microsoft/vscode-python#20270

@DonJayamanne This PR adds a field to the options that should allow you
to skip environment selection.
--------------------
Commit message for microsoft/vscode-python@672d07e:

Do not use `-I` flag in case we're unable to find `encodings` module when validating python (microsoft/vscode-python#20803)

Closes microsoft/vscode-python#20793
--------------------
Commit message for microsoft/vscode-python@2442dfb:

Add logging which could help indicate why `Discovering Python Interpreters...` never finishes (microsoft/vscode-python#20792)

For microsoft/vscode-python#20250
--------------------
Commit message for microsoft/vscode-python@e8303bb:

Fix ability to recognize extensions which access environment API (microsoft/vscode-python#20791)

Follow up from microsoft/vscode-python#20222.

Apparently `setTimeout` changed the stack in such a way that we were
unable to recognize which extension called the API:
```
[DEBUG 2023-2-2 16:21:9.641]: Extension unknown accessed getActiveEnvironmentPath with args: undefined
```
Reverting the change.
--------------------
Commit message for microsoft/vscode-python@ee8e80e:

Improve getting started experience when starting on a fresh macOS (microsoft/vscode-python#20789)

Closes microsoft/vscode-python#20635

- Suggest to install from `python.org` if brew is not available
- Do not suggest irrelevant prompts
--------------------
Commit message for microsoft/vscode-python@16c0437:

Update description of `python.terminal.activateEnvironment` setting (microsoft/vscode-python#20788)


--------------------
Commit message for microsoft/vscode-python@54e37fe:

Update README.md for isort changes (microsoft/vscode-python#20787)

Updating the README to reflect isort not being installed by default
--------------------
Commit message for microsoft/vscode-python@32c10e4:

Add verbose logging for change events fired related to envs (microsoft/vscode-python#20780)

For microsoft/vscode-python#20292
--------------------
Commit message for microsoft/vscode-python@be75eb2:

Ensure both `python` and `pythonPath` are not set when resolving config. (microsoft/vscode-python#20781)

Fixes microsoft/vscode-python#20655
--------------------
Commit message for microsoft/vscode-python@a5005f6:

Ensure picker returns array only if multi-select is enabled (microsoft/vscode-python#20772)

Fixes microsoft/vscode-python#20768
--------------------
Commit message for microsoft/vscode-python@c5e6378:

Update main to next pre-release (microsoft/vscode-python#20764)


--------------------
Commit message for microsoft/vscode-python@7c31a5e:

Updating version for release candidate. (microsoft/vscode-python#20762)


--------------------
Commit message for microsoft/vscode-python@e624eff:

Make sure conda activate is used for micromamba (microsoft/vscode-python#20760)

Closes microsoft/vscode-python#20756
--------------------
Commit message for microsoft/vscode-python@29bee00:

Fix debugger attach to process when running on WSL (microsoft/vscode-python#20741)

Possible fix for microsoft/vscode-python#16921

Closes microsoft/vscode-python#16921

BTW you folks should probably ask GitHub support to eject this repo from
their original repository (so it stops being a fork and has its own
network on GH)
--------------------
Commit message for microsoft/vscode-python@e9dba6c:

Bump typing-extensions from 4.4.0 to 4.5.0 (microsoft/vscode-python#20704)

Bumps [typing-extensions](https://github.com/python/typing_extensions)
from 4.4.0 to 4.5.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/python/typing_extensions/blob/main/CHANGELOG.md">typing-extensions's
changelog</a>.</em></p>
<blockquote>
<h1>Release 4.5.0 (February 14, 2023)</h1>
<ul>
<li>Runtime support for PEP 702, adding
<code>typing_extensions.deprecated</code>. Patch
by Jelle Zijlstra.</li>
<li>Add better default value for TypeVar <code>default</code> parameter,
PEP 696. Enables
runtime check if <code>None</code> was passed as default. Patch by Marc
Mueller (<a
href="https://github.com/cdce8p"><code>@​cdce8p</code></a>).</li>
<li>The <code>@typing_extensions.override</code> decorator now sets the
<code>.__override__</code>
attribute. Patch by Steven Troxler.</li>
<li>Fix <code>get_type_hints()</code> on cross-module inherited
<code>TypedDict</code> in 3.9 and 3.10.
Patch by Carl Meyer.</li>
<li>Add <code>frozen_default</code> parameter on
<code>dataclass_transform</code>. Patch by Erik De Bonte.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/python/typing_extensions/commit/8dcd89993c3926d6c704232b9c56160447fa81fe"><code>8dcd899</code></a>
Prepare release 4.5.0 (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/116">#116</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/e81cb8289874d6a6715675d77df88db033824e0d"><code>e81cb82</code></a>
PEP 702: Runtime warnings (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/112">#112</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/1039bb2730e62e9763b8fd1d6a19ddd6bb0b6fe4"><code>1039bb2</code></a>
fix PEP 702 link in the <code>README.md</code> (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/108">#108</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/673e5ceea32f77d90531d4d5e77a7694edba7fba"><code>673e5ce</code></a>
Add <a
href="https://github.com/typing"><code>@​typing</code></a>_extensions.deprecated
(<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/105">#105</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/27646ecba87fe518566db3d6b970574ad8df2490"><code>27646ec</code></a>
Fix tests on Python 3.11 (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/106">#106</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/57226b4fb64a5d9f4788e74fe3799d98fe02026b"><code>57226b4</code></a>
Add <code>frozen_default</code> parameter on
<code>dataclass_transform</code> (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/101">#101</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/0ea104bc37bd8f85246d48c7f6c7642f25771498"><code>0ea104b</code></a>
Expand the pyproject.toml sdist include expression to include
src/_typed_dict...</li>
<li><a
href="https://github.com/python/typing_extensions/commit/93ac93b58f23a2b7e4450cbe8819f5a36d319af7"><code>93ac93b</code></a>
CI: test on Ubuntu-20.04, not Ubuntu-2004 (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/100">#100</a>)</li>
<li><a
href="https://github.com/python/typing_extensions/commit/5f9258d1efd5d8e4900ffc23ba2486240f2a2f35"><code>5f9258d</code></a>
Test on Ubuntu 20.04</li>
<li><a
href="https://github.com/python/typing_extensions/commit/ad3966ddabe9adcbf2e76d88a7cf984fa9cb4237"><code>ad3966d</code></a>
Replace type comments with annotations (<a
href="https://github-redirect.dependabot.com/python/typing_extensions/issues/98">#98</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/python/typing_extensions/compare/4.4.0...4.5.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=typing-extensions&package-manager=pip&previous-version=4.4.0&new-version=4.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@35be3c2:

Ensure escape on TOML and requirements is treated as cancel. (microsoft/vscode-python#20739)


--------------------
Commit message for microsoft/vscode-python@5d9bc1e:

Tag Pylance settings properties for GDPR (microsoft/vscode-python#20745)


--------------------
Commit message for microsoft/vscode-python@70716f0:

Add description for `python.experiment` settings values (microsoft/vscode-python#20751)


--------------------
Commit message for microsoft/vscode-python@7b488a9:

Point to Python v3.11 instead of Python v3.10 when opening windows store (microsoft/vscode-python#20742)

Closes microsoft/vscode-python#20736

Lead-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
Co-authored-by: Jonathan Cardoso <me@jonathancardoso.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: paulacamargo25 <paulitacv25@gmail.com>
Co-authored-by: Pete Farland <pete.farland@posit.co>
Co-authored-by: Heejae Chang <1333179+heejaechang@users.noreply.github.com>
Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log ComSpec and add diagnostic to validate it
4 participants