Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow updates to pip #4087

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Slow updates to pip #4087

merged 2 commits into from
Jan 22, 2019

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Jan 22, 2019 •
edited

v19.0 breaks our CI

For #4082

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@d3r3kk
Slow updates to pip
ac41b5e 
- v19.0 breaks our CI
ericsnowcurrently
ericsnowcurrently approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming it works as expected)

DonJayamanne
DonJayamanne requested changes Jan 22, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@d3r3kk d3r3kk added the no-changelog No news entry required label Jan 22, 2019
@d3r3kk
Copy link
Author

d3r3kk commented Jan 22, 2019

Issue #4089 will track the update to pip 19

@DonJayamanne
Copy link

Please merge

@d3r3kk d3r3kk merged commit 1517b12 into microsoft:master Jan 22, 2019
@d3r3kk d3r3kk deleted the pip_update_breaks_ci branch January 22, 2019 22:39
DonJayamanne pushed a commit that referenced this pull request Jan 22, 2019
@d3r3kk @DonJayamanne
Slow updates to pip (#4087)
882d606 
- v19.0 breaks our CI
DonJayamanne added a commit that referenced this pull request Jan 24, 2019
@DonJayamanne
Merge branch 'release' into mergeRelease1
cc3f7fa 
* release:
  Add watermark for input box (#4117) (#4124)
  Cherry pick fix input bugs into release (#4121)
  Update version of language server to 0.1.78 (#4080)
  Slow updates to pip (#4087)
  Release candidate for Jan 2019.1.1
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d3r3kk @DonJayamanne @ericsnowcurrently