Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watermark for input box (#4117) #4124

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jan 24, 2019

  • Add watermark for input box

  • Add news entry

  • Fix hygiene after merge

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

* Add watermark for input box

* Add news entry

* Fix hygiene after merge
@rchiodo rchiodo self-assigned this Jan 24, 2019
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #4124 into release will increase coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           release   #4124   +/-   ##
=======================================
+ Coverage       79%     79%   +1%     
=======================================
  Files          407     407           
  Lines        18645   18646    +1     
  Branches      3007    3007           
=======================================
+ Hits         14609   14615    +6     
+ Misses        4033    4028    -5     
  Partials         3       3
Flag Coverage Δ
#Linux 68% <100%> (ø) ⬇️
#Windows 68% <100%> (+1%) ⬆️
#macOS 68% <100%> (+1%) ⬆️

@rchiodo rchiodo merged commit 5b78b08 into release Jan 24, 2019
@rchiodo rchiodo deleted the rchiodo/release/watermark branch January 24, 2019 01:04
DonJayamanne added a commit that referenced this pull request Jan 24, 2019
* release:
  Add watermark for input box (#4117) (#4124)
  Cherry pick fix input bugs into release (#4121)
  Update version of language server to 0.1.78 (#4080)
  Slow updates to pip (#4087)
  Release candidate for Jan 2019.1.1
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant