Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick fix input bugs into release #4121

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Cherry pick fix input bugs into release #4121

merged 2 commits into from
Jan 23, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jan 23, 2019

For #4076, #4084, #4086, #4088

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

rchiodo and others added 2 commits January 23, 2019 14:58
@rchiodo
Fix a number of issues with the input prompt (#4108)
671862f 
* Fix focus problems

* Switch to a grid layout to get more consistent results

* Add news entries

* Fix hygiene issues

* Fix 4088 - sys info not showing up
@rchiodo
Update changelog
0710246
@rchiodo rchiodo self-assigned this Jan 23, 2019
@rchiodo rchiodo merged commit 6d7c012 into release Jan 23, 2019
@rchiodo rchiodo deleted the rchiodo/release/fix_input_bugs branch January 24, 2019 01:03
DonJayamanne added a commit that referenced this pull request Jan 24, 2019
@DonJayamanne
Merge branch 'release' into mergeRelease1
cc3f7fa 
* release:
  Add watermark for input box (#4117) (#4124)
  Cherry pick fix input bugs into release (#4121)
  Update version of language server to 0.1.78 (#4080)
  Slow updates to pip (#4087)
  Release candidate for Jan 2019.1.1
@rchiodo
Copy link
Author

rchiodo commented Jan 24, 2019 via email

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rchiodo