vsce package is broken with npm workspaces

[billti]

See microsoft/qsharp#1091 where I had to pin to 2.22.0 to get our build to work again.

With 2.23.0 I get an error message running "vsce package --pre-release" that

 ERROR  Extension entrypoint(s) missing. Make sure these files exist and aren't ignored by '.vscodeignore':
  extension/out/extension.js

But the extension is in ./out/extension.js and always has been. You can see this specified at https://github.com/microsoft/qsharp/blob/main/vscode/package.json#L20 .

Pinning back to 2.22.0 resolves the issue.

I haven't had a chance to dig into this more yet. Raising ASAP for awareness.

[mweichert]

Having this issue as well.

[Kubessandra]

Same

[remcohaszing]

This also affects non-browser extensions.

[goto40]

same effect for me.

[lars-reimann]

I've had the same issue after updating to v2.23.0 (see this CI run):

Error: Extension entrypoint(s) missing. Make sure these files exist and aren't ignored by '.vscodeignore':
extension/dist/extension/mainClient.cjs

vsce ls still shows that the file dist/extension/mainClient.cjs exists and v2.22.0 works fine.

[sandy081]

Looks like this is something do with yarn workspaces feature support - #300

I believe those who are seeing this issue has your projects using yarn workspaces?

[sandy081]

Can you please try adding following flag --yarn to package command and see if it fixes?

for eg: vsce package --yarn

[goto40]

your projects using yarn workspaces?

No, but npm workspaces... I build the vsix in a project embedded in an npm workspace. I have no problem with a previous version of vsce.

[remcohaszing]

I ran into this in mdx-analyzer, which uses npm workspaces.

The output of the failed GitHub action is available on https://github.com/mdx-js/mdx-analyzer/actions/runs/7756736096/job/21154662574

[lars-reimann]

Looks like this is something do with yarn workspaces feature support - #300

I believe those who are seeing this issue has your projects using yarn workspaces?

NPM workspaces for me as well.

[billti]

Seems we have a common pattern. Our VS Code package is also part of an npm workspace (https://github.com/microsoft/qsharp/blob/main/package.json).

[sandy081]

I can reproduce this with npm workspaces. Will work on the fix. Thanks for info.

[isidorn]

Thank you for reporting this and for helping us find the issue.
We have started the investigation and I expect us to have a fix next week.
Until then I suggest to use the older version of vsce 2.22.0.

Sorry about that and thank you for your patience 🙏

[cipherdmg]

Hello Team,

First VSCode is simply awesome.

I also hit this exact same issue since I am not using yarn workspaces but I am using npm workspaces.

I did notice though just the presence of a .yarn folder even though I don't use yarn or have yarn dependencies then it works even though it does not use yarn. If I remove that folder then it breaks.

The paths to the extension are not resolving.

The npm.js getNpmDependencies() normalizes files from the directory where the package.json has workspaces in it which is 2 levels higher so I end up with normalized paths like this.

extension/../../apps/vscode/dist/extension.js

My package.json for my extension has "main": "./dist/extension.js", I also tried "main": "dist/extension.js",

So when it goes into package.js

onFile(file) {
    this.entryPoints.delete(util.normalize(file.path));
    return Promise.resolve(file);
}

This code that tries to delete the entryPoints LaunchEntryPointProcessor tries to delete the entryPoints but since they don't match it does not get deleted and then onFile() is called and throws an error.

Hope the screen shot helps. My monorepo is broken so I have to move back to v2.22.0 until this gets fixed.

Thanks
CipherDMG

[sedrubal]

I ran into an issue which looks exactly similar to this one. However, I don't use workspaces. The reason was, that I've installed the Ubuntu snap nodejs package, which is broken. ➡️ Don't use snap

[joaomoreno]

vsce 2.24.0 is out, can you see if that helps? Thanks for letting us know.

[lars-reimann]

vsce 2.24.0 is out, can you see if that helps? Thanks for letting us know.

vsce package works again for Safe-DS/DSL using v2.24.0. Thanks for the fix!

[billti]

Seems to be working for us now. Thanks!

[cipherdmg]

Thanks team, this resolved my issue also.

[goto40]

Works for me, too. Thank you!