Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for yarn workspaces #493

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

sebas2day
Copy link
Contributor

Fixes #300

This PR is inspired by #379.

I have included a small yarn workspaces fixture in order to test whether its collecting the files in the right way.

@sebas2day
Copy link
Contributor Author

@joaomoreno I resolved the merge conflicts with master. Any chance you can give this PR a review?

@joaomoreno
Copy link
Member

Thanks for bring this up-to-date.

@phaumer Hmm yes the .vscodeignore file might not fully work as expected. I think it would be good to first merge this PR #418 to make the implementation of .vscodeignore simpler so we can eventually fix it later in this PR

In #458 (comment). Is this still your opinion? Should #418 go in first?

@sebas2day
Copy link
Contributor Author

Only when you're actually considering it. If not, I can have another look at the .vscodeignore to see if I can fix it.

I'm fine with both.

Base automatically changed from master to main February 10, 2021 14:44
@sebas2day
Copy link
Contributor Author

@joaomoreno Ok, I checked and the .vscodeignore is working actually. I included it in the tests so you can have a look.

Specifically for @phaumer use-case it would be a new feature request. The current functionality (in the main branch) does not allow you to include files that are "outside" of your package (+dependencies) scope.

@joaomoreno joaomoreno self-assigned this Mar 5, 2021
@bporterfield
Copy link

hello! any update on this? we're looking to move to yarn2 and this package is not yet compatible. There is a hacky workaround but would be nice to have this supported.

@thegecko thegecko mentioned this pull request Nov 24, 2021
@v-karbovnichy
Copy link

are we there yet?

already 2022.

@Blackclaws
Copy link

@joaomoreno Is there anything still missing on this PR that prevents it currently from getting merged?

@mull
Copy link

mull commented Mar 1, 2023

2023!

@joaomoreno
Copy link
Member

@sebas2day Sorry for the delay here. I've brought the PR forward by merging main onto it, resolving conflicts and fixing some type errors. Want to do one final review, and I'll merge once you give me your thumbs up?

@joaomoreno joaomoreno added this to the December 2023 milestone Dec 5, 2023
@sebas2day
Copy link
Contributor Author

Yes feel free to merge it 👍

@joaomoreno joaomoreno modified the milestones: December 2023, December / January 2024 Dec 11, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) December 13, 2023 12:20
@joaomoreno
Copy link
Member

Thank you for your patience! 🍻

@joaomoreno joaomoreno merged commit 3e8410b into microsoft:main Dec 13, 2023
15 checks passed
@v-karbovnichy
Copy link

v-karbovnichy commented Dec 13, 2023

wow, finally, thanks everyone for support!

however I completely forgot why did I need this thing to be implemented.

that was 4 projects ago, 2 companies ago...

joaomoreno added a commit that referenced this pull request Feb 23, 2024
@joaomoreno
Copy link
Member

Sadly, I will revert this due to:

joaomoreno added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support yarn workspaces
7 participants