Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'trailing' option to 'editor.renderWhitespace' #104310

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Add 'trailing' option to 'editor.renderWhitespace' #104310

merged 2 commits into from
Aug 31, 2020

Conversation

stnrepin
Copy link
Contributor

@stnrepin stnrepin commented Aug 8, 2020

This PR fixes #43127

Add a new option ('trailing') to editor.renderWhitespace that renders only trailing whitespace (including lines with only whitespace).

@ghost
Copy link

ghost commented Aug 8, 2020

CLA assistant check
All CLA requirements met.

@alexdima alexdima added this to the August 2020 milestone Aug 31, 2020
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit 29e9717 into microsoft:master Aug 31, 2020
@noinkling
Copy link

Any chance we could get a way to combine both the selection and trailing options? Maybe selection should be its own setting?

@stnrepin
Copy link
Contributor Author

I also think the selection option doesn't correspond to other options in editor.renderWhitespace: it works like all but only for selected text, therefore playing a slightly different role. Moreover, as you said, extracting selection to its own setting will increase customization capabilities (will allow combine options). So, I like your idea.

My little investigation showed that realization shouldn't be hard, so I can create the issue (where we can discuss the details) and implement this feature if @alexdima finds it acceptable.

@krid
Copy link

krid commented Sep 29, 2020

There's now a relevant bug: #106697
Go forth and upvote it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trailing option to editor.renderWhitespace
4 participants