-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webview doesn't load resources on WSL2 #105536
Comments
(Experimental duplicate detection) |
Does this reproduce in the latest VS Code insiders build build too? |
Just installed the latest insiders build and the problem didn't seem to happen. Seems that when I start either VS Code with the WLS 2 distro is already running it works, but when VS Code has to start the distro it doesn't. By the way, I never use the terminal to start VS Code. It is always through the Windows executable shortcut. VS Code version: Code - Insiders 1.49.0-insider (b58f454, 2020-08-27T05:47:18.302Z) System Info
Extensions (2)
|
Am still seeing this issue with 1.50.1
In WSL
|
While this doesn't get fixed my workaround is to boot WSL with Windows Terminal before opening VS Code. Works every time. Hope this helps. |
I'm having the same issues with the Git Graph extension: Related: #106667, mhutchie/vscode-git-graph#378 |
Just to note that I also see this defect current version info: Git graph v1.28.0 Version: 1.52.1 (system setup) For me the issue is intermittent- I haven't spotted any pattern about when it occurs. |
Yeah, something changed on update 1.53.1 and now the workaround doesn't work anymore. Remote - WSL Extension version: 0.53.3 System Info
A/B Experiments
|
So I turned on [2021-02-09 17:02:32.017] [main] [debug] loadLocalResource - being. requestUri=vscode-webview-resource://6465c1a9-e4ba-483e-9c9a-822011f2fbbd/file///home/leandro/.vscode-server/extensions/mhutchie.git-graph-1.28.0/media/out.min.js
[2021-02-09 17:02:32.017] [main] [debug] loadLocalResource - found resource to load. requestUri=vscode-webview-resource://6465c1a9-e4ba-483e-9c9a-822011f2fbbd/file///home/leandro/.vscode-server/extensions/mhutchie.git-graph-1.28.0/media/out.min.js, resourceToLoad=file:///home/leandro/.vscode-server/extensions/mhutchie.git-graph-1.28.0/media/out.min.js
[2021-02-09 17:02:32.017] [main] [trace] RequestService#request http://::1:45475/vscode-remote-resource?tkn=959f3d08-21d7-42fa-adb8-79b10d6893b3&path=%2Fhome%2Fleandro%2F.vscode-server%2Fextensions%2Fmhutchie.git-graph-1.28.0%2Fmedia%2Fout.min.js
[2021-02-09 17:02:32.020] [main] [debug] loadLocalResource - Loaded over http(s). requestUri=vscode-webview-resource://6465c1a9-e4ba-483e-9c9a-822011f2fbbd/file///home/leandro/.vscode-server/extensions/mhutchie.git-graph-1.28.0/media/out.min.js, response=404 It seems the URI Using Chrome to simulate the requests, |
Very good find @leandro-manifesto! Ipv6 address could also explain why some people consistently see this while others don't (I don't seem to see it on my machine, but I'm running windows under parallels which may cause weird network things) The problematic line is likely:
I'll look into checking in a fix but will likely need someone else to verify that it actually works. |
For #105536 but need verification from someone who can actually reproduce this bug
Just pushed potential fix which will be in the next insiders build. Please test it out and let me know if this resolves the problem or not |
The current Insiders build is on commit cd97629, so I'm waiting for the new one to come out. |
Tested on this build: Version: 1.54.0-insider Seems to be working. Git Graph opened properly. Tested once with an already running WSL2, but it was using IPv4. [2021-02-10 17:44:32.027] [main] [debug] loadLocalResource - being. requestUri=vscode-webview-resource://81374fcd-9910-4675-8dac-a10636112175/file///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.css
[2021-02-10 17:44:32.028] [main] [debug] loadLocalResource - found resource to load. requestUri=vscode-webview-resource://81374fcd-9910-4675-8dac-a10636112175/file///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.css, resourceToLoad=file:///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.css
[2021-02-10 17:44:32.028] [main] [trace] RequestService#request http://[::1]:36243/vscode-remote-resource?tkn=a8c7982c-9c5d-48e2-a617-03b14f27e82f&path=%2Fhome%2Fleandro%2F.vscode-server-insiders%2Fextensions%2Fmhutchie.git-graph-1.28.0%2Fmedia%2Fout.min.css
[2021-02-10 17:44:32.029] [main] [debug] loadLocalResource - being. requestUri=vscode-webview-resource://81374fcd-9910-4675-8dac-a10636112175/file///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.js
[2021-02-10 17:44:32.029] [main] [debug] loadLocalResource - found resource to load. requestUri=vscode-webview-resource://81374fcd-9910-4675-8dac-a10636112175/file///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.js, resourceToLoad=file:///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.js
[2021-02-10 17:44:32.030] [main] [trace] RequestService#request http://[::1]:36243/vscode-remote-resource?tkn=a8c7982c-9c5d-48e2-a617-03b14f27e82f&path=%2Fhome%2Fleandro%2F.vscode-server-insiders%2Fextensions%2Fmhutchie.git-graph-1.28.0%2Fmedia%2Fout.min.js
[2021-02-10 17:44:32.034] [main] [debug] loadLocalResource - Loaded over http(s). requestUri=vscode-webview-resource://81374fcd-9910-4675-8dac-a10636112175/file///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.css, response=200
[2021-02-10 17:44:32.036] [main] [debug] loadLocalResource - Loaded over http(s). requestUri=vscode-webview-resource://81374fcd-9910-4675-8dac-a10636112175/file///home/leandro/.vscode-server-insiders/extensions/mhutchie.git-graph-1.28.0/media/out.min.js, response=200 Each time I open VS Code it seems random if I'll get IPv4 or IPv6, don't know why. |
Thanks for checking. Closing but please let me know if you see this bug using the latest insiders builds of VS Code |
What's the lead time for making this fix generally available? |
I can confirm this fixes the issue in vscode insiders 1.54.0. And I can also confirm @leandro-manifesto diagnosis on vscode 1.53.2 as I also saw in the logs the ipv6 address without the [], resulting in 404s, when getting the js and css of git graph. |
Looks like this has been verified by two of the original people who saw this issue. Thanks for verifying! |
Issue Type: Bug
Seems to be #101272, but that issue is locked.
It started happenning when I updated to 1.48 and happens most of the time when I open Git Graph.
Sometimes it does work properly but I still couldn't figure out why.
VS Code version: Code 1.48.2 (a047975, 2020-08-25T10:13:11.295Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Extensions (8)
The text was updated successfully, but these errors were encountered: