Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Graph broken as of VS Code 1.52? #436

Closed
robvitaro opened this issue Dec 14, 2020 · 3 comments
Closed

Git Graph broken as of VS Code 1.52? #436

robvitaro opened this issue Dec 14, 2020 · 3 comments
Assignees
Labels
vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions.

Comments

@robvitaro
Copy link

Describe the Bug
As of VSCode 1.52 I cannot display GitGraph

Steps to Reproduce
Steps to reproduce the behavior:

  1. Click "Git Graph" button on the status bar at the bottom of the application
  2. See screenshot below

Expected Behavior
I expect to see the graph

Environment

  • Git Graph Extension Version: 1.28
  • Visual Studio Code Version: 1.52
  • Operating System: Windows 10

VS Code details
Version: 1.52.0 (user setup)
Commit: 940b5f4bb5fa47866a54529ed759d95d09ee80be
Date: 2020-12-10T22:45:11.850Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

Screenshots (optional)

image

@robvitaro robvitaro added the bug Something isn't working label Dec 14, 2020
@mhutchie mhutchie added vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions. and removed bug Something isn't working labels Dec 14, 2020
@mhutchie
Copy link
Owner

Hi @robvitaro,

I've had no other reports of this occurring for any other users after upgrading to Visual Studio Code 1.52.0. After every release I always also check the extension myself on multiple operating systems (I didn't notice anything either).

This behaviour occurs when Visual Studio Code fails to load the CSS & JS resources packaged in the extension that the Git Graph View requires. If you run the "Developer: Open Webview Developer Tools" command from the Visual Studio Code Command Palette, and switch to the Console Tab, you'll be able to see the errors that Visual Studio Code is having. These error logs will tell you to path of the two required files out.min.js and out.min.css.

There are two possible causes of the behaviour you've observed:

  1. In rare cases it's possible that Visual Studio Code incorrectly unpacks the extension when it was last installed, or for some reason some of the extensions files on disk were deleted. To check if this is the case, check your file system for the files I mentioned above in the error logs. If they do not exist, you just need install a previous version of Git Graph, and then update back to the latest version to restore these files.
  2. This is caused by a Visual Studio Code bug with their Webview implementation, that affects all extensions that use Webview's (not just Git Graph). Unfortunately there have been numerous of these Visual Studio Code Webview bugs this year (many are related to the compatibility with WSL Visual Studio Code Bug with WSL2 preventing the Git Graph View from loading #378 - this one Webview doesn't load resources on WSL2 microsoft/vscode#105536 is still open). Please follow it for Microsoft's resolution of this issue, or raise a new bug with Microsoft if out.min.js and out.min.css are on you computer in the correct location, but Visual Studio Code is failing to provide them in the Git Graph View's Webview. Visual Studio Code is responsible for creating Webview's for extensions, and providing the resources that the extensions require (they don't allow any other method).

I'll close this issue as either:

  • You just need to follow the steps I mentioned in (1), and there is nothing I can do about these files not existing on your computer (the extension definitely has no way of deleting them).
  • It is a Visual Studio Code bug, and either this is the same as the issue that's already being tracked by Microsoft, or you should open a new issue in their repo (e.g. "Unable to load Webview's resources").

@robvitaro
Copy link
Author

@mhutchie, I appreciate you taking the time to give such a detailed response. Looks as if my problem is 2, as I use WSL 2. I used one of the commenters' suggestion of starting WSL before opening VS Code, that is an acceptable workaround. Thanks so much.

@mhutchie
Copy link
Owner

Hi @robvitaro,

Thanks for letting me know that this is WSL2 related! I'm glad you have an acceptable workaround until it is properly fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions.
Projects
None yet
Development

No branches or pull requests

2 participants