Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio crashing when MacBookPro wakes from sleep... #108860

Closed
wdarm opened this issue Oct 17, 2020 · 8 comments
Closed

Visual Studio crashing when MacBookPro wakes from sleep... #108860

wdarm opened this issue Oct 17, 2020 · 8 comments
Assignees
@deepak1556
Labels
electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues macos-catalina upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@wdarm
Copy link

wdarm commented Oct 17, 2020

I'm not positive what is causing it...
I think Code is crashing when my machine wakes up and is enumerating the displays.
I have one display on HDMI and on on DiplayPort both on a CalDigit Dock. Displays come up at different times and when the screens come back VSCode is no longer running.
@josephinoo
Copy link

wow

@wdarm
Copy link
Author

wdarm commented Oct 18, 2020

It looks like 1.50.1 release may have fixed the problem. I haven't seen it since the last update -- will close this in a few days if I don't see it again.

@wdarm
Copy link
Author

wdarm commented Oct 19, 2020

OK - no -- it happened again... Put my machine to sleep when I woke it up and unlocked it VisualStudio Code was crashed.

I dug into my Library directory and I have dmp files in the crashpad directory. Attached in a zip.
CrashPadDumps.zip

@wdarm
Copy link
Author

wdarm commented Oct 19, 2020

OK - further information --- It happens on both of my machines - my personal Mac and my work Mac.
I don't share a configuration between them or anything like that -- but I do swap them both through the same dock.

They are more or less the same HW config Mac Book Pro 16".

@deepak1556
Copy link
Collaborator

Thanks for the dumps, the symbolicated trace

Operating system: Mac OS X
                  10.15.7 19H2
CPU: amd64
     family 6 model 158 stepping 13
     16 CPUs

GPU: UNKNOWN

Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash address: 0x7fb0deb00000
Process uptime: 144183 seconds

Thread 0 (crashed)
 0  libsystem_platform.dylib!_platform_memmove$VARIANT$Haswell + 0x13c
    rax = 0x00007fb05c489168   rdx = 0x000000000000003c
    rcx = 0x0000000000000018   rbx = 0x00007fb05c489130
    rsi = 0x00007fb0deaffff8   rdi = 0x00007fb05c489300
    rbp = 0x00007ffeef67f680   rsp = 0x00007ffeef67f680
     r8 = 0x000000000000850c    r9 = 0x0000000000008530
    r10 = 0x00000000ffff0000   r11 = 0xffffffff7d989308
    r12 = 0x00007fb0deaffe60   r13 = 0x00007fb0da670eb0
    r14 = 0x00007ffeef67f698   r15 = 0x00007fb0da419160
    rip = 0x00007fff6bc02a3c
    Found by: given as instruction pointer in context
 1  Electron Framework!electron::api::Screen::OnDisplayAdded(display::Display const&) [tuple : 232 + 0xc]
    rbp = 0x00007ffeef67f6f0   rsp = 0x00007ffeef67f690
    rip = 0x00000001076485c7
    Found by: previous frame's frame pointer
 2  Electron Framework!display::DisplayChangeNotifier::NotifyDisplaysChanged(std::__1::vector<display::Display, std::__1::allocator<display::Display> > const&, std::__1::vector<display::Display, std::__1::allocator<display::Display> > const&) [display_change_notifier.cc : 65 + 0x9]
    rbp = 0x00007ffeef67f770   rsp = 0x00007ffeef67f700
    rip = 0x000000010ac2e7eb
    Found by: previous frame's frame pointer
 3  Electron Framework!display::(anonymous namespace)::ScreenMac::ConfigureTimerFired() [screen_mac.mm : 348 + 0x8]
    rbp = 0x00007ffeef67f7c0   rsp = 0x00007ffeef67f780
    rip = 0x000000010ac304cc
    Found by: previous frame's frame pointer
 4  Electron Framework!base::RetainingOneShotTimer::RunUserTask() [callback.h : 132 + 0x3]
    rbp = 0x00007ffeef67f7f0   rsp = 0x00007ffeef67f7d0
    rip = 0x0000000109b4d53e
    Found by: previous frame's frame pointer
 5  Electron Framework!base::TaskAnnotator::RunTask(char const*, base::PendingTask*) [callback.h : 98 + 0x3]
    rbp = 0x00007ffeef67f8a0   rsp = 0x00007ffeef67f800
    rip = 0x0000000109b20b6f
    Found by: previous frame's frame pointer
 6  Electron Framework!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) [thread_controller_with_message_pump_impl.cc : 324 + 0xf]
    rbp = 0x00007ffeef67f970   rsp = 0x00007ffeef67f8b0
    rip = 0x0000000109b30d4a
    Found by: previous frame's frame pointer
 7  Electron Framework!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() [thread_controller_with_message_pump_impl.cc : 248 + 0xb]
    rbp = 0x00007ffeef67f9c0   rsp = 0x00007ffeef67f980
    rip = 0x0000000109b30ad9
    Found by: previous frame's frame pointer
 8  Electron Framework!invocation function for block in base::MessagePumpCFRunLoopBase::RunDelayedWorkTimer(__CFRunLoopTimer*, void*) [message_pump_mac.mm : 499 + 0x6]
    rbp = 0x00007ffeef67f9e0   rsp = 0x00007ffeef67f9d0
    rip = 0x0000000109b814c1
    Found by: previous frame's frame pointer
 9  Electron Framework!base::mac::CallWithEHFrame(void () block_pointer) + 0xa
    rbp = 0x00007ffeef67f9f0   rsp = 0x00007ffeef67f9f0
    rip = 0x0000000109b7ccfa
    Found by: previous frame's frame pointer
10  Electron Framework!base::MessagePumpCFRunLoopBase::RunDelayedWorkTimer(__CFRunLoopTimer*, void*) [message_pump_mac.mm : 466 + 0x5]
    rbp = 0x00007ffeef67fa40   rsp = 0x00007ffeef67fa00
    rip = 0x0000000109b80d93
    Found by: previous frame's frame pointer
11  CoreFoundation!__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 0x14
    rbp = 0x00007ffeef67fa50   rsp = 0x00007ffeef67fa50
    rip = 0x00007fff319b77f9
    Found by: previous frame's frame pointer
12  CoreFoundation!__CFRunLoopDoTimer + 0x35b
    rbp = 0x00007ffeef680b00   rsp = 0x00007ffeef67fa60
    rip = 0x00007fff319b735f
    Found by: previous frame's frame pointer
13  CoreFoundation!__CFRunLoopDoTimers + 0x142
    rbp = 0x00007ffeef680b80   rsp = 0x00007ffeef680b10
    rip = 0x00007fff319b6e47
    Found by: previous frame's frame pointer
14  CoreFoundation!__CFRunLoopRun + 0x74f
    rbp = 0x00007ffeef681890   rsp = 0x00007ffeef680b90
    rip = 0x00007fff3199bbea
    Found by: previous frame's frame pointer
15  CoreFoundation!CFRunLoopRunSpecific + 0x1ce
    rbp = 0x00007ffeef681920   rsp = 0x00007ffeef6818a0
    rip = 0x00007fff3199ae3e
    Found by: previous frame's frame pointer
16  HIToolbox!RunCurrentEventLoopInMode + 0x124
    rbp = 0x00007ffeef681970   rsp = 0x00007ffeef681930
    rip = 0x00007fff305c7abd
    Found by: previous frame's frame pointer
17  HIToolbox!ReceiveNextEventCommon + 0x248
    rbp = 0x00007ffeef6819f0   rsp = 0x00007ffeef681980
    rip = 0x00007fff305c77d5
    Found by: previous frame's frame pointer
18  HIToolbox!_BlockUntilNextEventMatchingListInModeWithFilter + 0x40
    rbp = 0x00007ffeef681a10   rsp = 0x00007ffeef681a00
    rip = 0x00007fff305c7579
    Found by: previous frame's frame pointer
19  AppKit!_DPSNextEvent + 0x373
    rbp = 0x00007ffeef681e10   rsp = 0x00007ffeef681a20
    rip = 0x00007fff2ec0d039
    Found by: previous frame's frame pointer
20  AppKit!-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 0x548
    rbp = 0x00007ffeef682070   rsp = 0x00007ffeef681e20
    rip = 0x00007fff2ec0b880
    Found by: previous frame's frame pointer
21  AppKit!-[NSApplication run] + 0x292
    rbp = 0x00007ffeef682130   rsp = 0x00007ffeef682080
    rip = 0x00007fff2ebfd58e
    Found by: previous frame's frame pointer
22  Electron Framework!base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) [message_pump_mac.mm : 835 + 0xd]
    rbp = 0x00007ffeef682190   rsp = 0x00007ffeef682140
    rip = 0x0000000109b81d7c
    Found by: previous frame's frame pointer
23  Electron Framework!base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) [message_pump_mac.mm : 190 + 0xc]
    rbp = 0x00007ffeef6821d0   rsp = 0x00007ffeef6821a0
    rip = 0x0000000109b807e2
    Found by: previous frame's frame pointer
24  Electron Framework!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) [thread_controller_with_message_pump_impl.cc : 429 + 0x6]
    rbp = 0x00007ffeef682200   rsp = 0x00007ffeef6821e0
    rip = 0x0000000109b312d3
    Found by: previous frame's frame pointer
25  Electron Framework!base::RunLoop::Run() [run_loop.cc : 124 + 0x13]
    rbp = 0x00007ffeef682290   rsp = 0x00007ffeef682210
    rip = 0x0000000109b090b3
    Found by: previous frame's frame pointer
26  Electron Framework!content::BrowserMainLoop::RunMainMessageLoopParts() [browser_main_loop.cc : 1496 + 0x8]
    rbp = 0x00007ffeef682300   rsp = 0x00007ffeef6822a0
    rip = 0x00000001083ca383
    Found by: previous frame's frame pointer
27  Electron Framework!content::BrowserMainRunnerImpl::Run() [browser_main_runner_impl.cc : 150 + 0x5]
    rbp = 0x00007ffeef682320   rsp = 0x00007ffeef682310
    rip = 0x00000001083cbd92
    Found by: previous frame's frame pointer
28  Electron Framework!content::BrowserMain(content::MainFunctionParams const&) [browser_main.cc : 47 + 0x6]
    rbp = 0x00007ffeef682370   rsp = 0x00007ffeef682330
    rip = 0x00000001083c7c38
    Found by: previous frame's frame pointer
29  Electron Framework!content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) [content_main_runner_impl.cc : 530 + 0x5]
    rbp = 0x00007ffeef6823f0   rsp = 0x00007ffeef682380
    rip = 0x000000010826ff06
    Found by: previous frame's frame pointer
30  Electron Framework!content::ContentMainRunnerImpl::Run(bool) [content_main_runner_impl.cc : 879 + 0x10]
    rbp = 0x00007ffeef682460   rsp = 0x00007ffeef682400
    rip = 0x000000010826fb5b
    Found by: previous frame's frame pointer
31  Electron Framework!service_manager::Main(service_manager::MainParams const&) [main.cc : 454 + 0x9]
    rbp = 0x00007ffeef6827b0   rsp = 0x00007ffeef682470
    rip = 0x000000010b2bfe08
    Found by: previous frame's frame pointer
32  Electron Framework!content::ContentMain(content::ContentMainParams const&) [content_main.cc : 19 + 0x8]
    rbp = 0x00007ffeef682840   rsp = 0x00007ffeef6827c0
    rip = 0x000000010826f224
    Found by: previous frame's frame pointer
33  Electron Framework!ElectronMain [electron_library_main.mm : 31 + 0x5]
    rbp = 0x00007ffeef6828d0   rsp = 0x00007ffeef682850
    rip = 0x00000001075efbd4
    Found by: previous frame's frame pointer
34  Electron!main [electron_main.cc : 287 + 0xa]
    rbp = 0x00007ffeef682980   rsp = 0x00007ffeef6828e0
    rip = 0x000000010057e110
    Found by: previous frame's frame pointer
35  libdyld.dylib!start + 0x1
    rbp = 0x00007ffeef682990   rsp = 0x00007ffeef682990
    rip = 0x00007fff6ba0ccc9
    Found by: previous frame's frame pointer

@deepak1556
Copy link
Collaborator

I think Code is crashing when my machine wakes up and is enumerating the displays.

yup that is correct assumption based on the above trace

@deepak1556 deepak1556 added electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues macos-catalina upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 20, 2020
@deepak1556 deepak1556 mentioned this issue Oct 20, 2020
Closed
3 tasks
@deepak1556
Copy link
Collaborator

Upstream issue electron/electron#24135

@deepak1556 deepak1556 added the upstream-issue-linked This is an upstream issue that has been reported upstream label Oct 20, 2020
@deepak1556
Copy link
Collaborator

Upstream issue has been marked fixed in newer versions, let us know if the issue still persists with latest stable.

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues macos-catalina upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepak1556 @wdarm @josephinoo