Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test resizable suggest widget #109394

Closed
2 tasks done
jrieken opened this issue Oct 26, 2020 · 2 comments
Closed
2 tasks done

Test resizable suggest widget #109394

jrieken opened this issue Oct 26, 2020 · 2 comments

Comments

@jrieken
Copy link
Member

jrieken commented Oct 26, 2020

Refs: #29126

Complexity: 4

Create Issue


The suggest widget is now resizable - that applies to the list of suggestions and the details panel. Test that

  • the list of suggestions is resizable
  • the details panel is resizable
  • there is good minimal sizes
  • the details panels doesn't steel space from the list
  • the list remembers a custom size
  • the list goes to "ideal" size when double clicking its resize sashes
    • the ideal height of the list is defined via editor.suggest.maxVisibleSuggestions
    • the ideal width is defined by the items
  • the details panels only remembers a custom size for the current sessions (comment here if you disagree The detail of a suggest does not remember its height #109360)
  • when resizing the list or window the details re-position themselves with this priority: left, right, below
  • the list preferrers to be shown below the cursor but shows above if there isn't enough space
  • the details align to top of the list unless they are too high in which case they align with the bottom of the list
@isidorn
Copy link
Contributor

isidorn commented Oct 27, 2020

Great work, I really like these changes.

@dbaeumer
Copy link
Member

Agree with @isidorn. None of my issue are critical (the are mostly corner cases) except may be #109447

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants