Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest widget details size should be remembered until end of suggest session #109462

Closed
isidorn opened this issue Oct 27, 2020 · 2 comments
Closed

Suggest widget details size should be remembered until end of suggest session #109462

isidorn opened this issue Oct 27, 2020 · 2 comments
Assignees
@jrieken
Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Milestone
October 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 27, 2020

Testing #109394

  1. Open suggest widget, open the details
  2. Resize the details view so it is very large
  3. Cmd + space to hide the details view. But the suggest is still visible
  4. Cmd + space to show the details again. The details does not preserve the size from step 3

I believe the size of the details view should be preserved until suggest widget gets closed.
@jrieken
Copy link
Member

jrieken commented Oct 27, 2020

Today it's implemented to drop it's custom size when hidden. Unsure what best?

@jrieken jrieken added suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach labels Oct 27, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Oct 27, 2020

I think closing suggest widget is the clear signal which we should use for all of these things (until when to remember something). That way it will be more consistent and easier for users to understand.

@jrieken jrieken added this to the October 2020 milestone Oct 27, 2020
jrieken added a commit that referenced this issue Oct 27, 2020
@jrieken
drop userSize at session end, not when hiding widget, #109462
5649909
@jrieken jrieken closed this as completed Oct 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
October 2020
Development

No branches or pull requests
2 participants
@jrieken @isidorn