Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep editors open instead of closing them when loading fails on startup #110062

Closed
bpasero opened this issue Nov 6, 2020 · 7 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan remote Remote system operations issues workbench-editors Managing of editor widgets in workbench window
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 6, 2020

Helps for microsoft/vscode-remote-release#3475

@CodeSammich
Copy link

For me, it seems to only occur in two scenarios:

  1. When disconnected from SSH, any options besides "Reload Window" is selected will remove old tabs (e.g. Close Remote)

  2. When disconnected from SSH due to inactivity and the auto-reconnect options are not given, possible due to "successful" reconnect. This may be due to the auto-reconnect using the same logic as "Close Remote" -> "Connect" instead of "Reload Window" after SSH connection is established.

@bpasero
Copy link
Member Author

bpasero commented Aug 16, 2021

Pushed a change to keep editors open when the fail to restore:

recording

This is enabled by default but depending on feedback might warrant for a setting. The editor will still close automatically when the act of opening an editor newly fails.

@apeforever
Copy link

Could you add a setting please ? Thanks a lot

@bpasero
Copy link
Member Author

bpasero commented Sep 3, 2021

Can you open a new feature request for that please.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan remote Remote system operations issues workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @CodeSammich @apeforever and others