Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.codeLensFontFamily setting only work temporarily on macOS 10.13.6 #116104

Closed
inetfuture opened this issue Feb 8, 2021 · 2 comments
Closed
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug code-lens insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@inetfuture
Copy link

inetfuture commented Feb 8, 2021

VS Code version: Code 1.53.0 (8490d3d, 2021-02-03T16:01:04.046Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: unavailable_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: unavailable_off
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.19GB free)
Process Argv -psn_0_90134 --crash-reporter-id fdea18b1-6d1e-46eb-a4e5-bd8e595aad3a
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30211401
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

Steps to Reproduce:

  1. Change global editor.codeLensFontFamily setting to 'Courier New'(a mono space font on macOS).
  2. Reload window.
  3. Open a file tracked by Git, Git CodeLens first shows with default font, then 'Courier New'.
  4. Switch to another file, Git CodeLens shows with default font, always.
  5. Swithc back to the first file, Git CodeLens shows with default font, always, 'Courier New' not working any more, font size works though.

Kapture 2021-02-08 at 21 09 53

Does this issue occur when all extensions are disabled?: Yes

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug code-lens labels Feb 8, 2021
@jrieken
Copy link
Member

jrieken commented Feb 8, 2021

I can reproduce. The font family is defined with a css variables and the dom node that holds the value of that variable isn't around yet when receiving configured styles...

@jrieken jrieken added this to the February 2021 milestone Feb 8, 2021
@jrieken jrieken closed this as completed in 75f4a58 Feb 8, 2021
@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Feb 25, 2021
@JacksonKearl JacksonKearl added the verified Verification succeeded label Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug code-lens insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@inetfuture @jrieken @rzhao271 @JacksonKearl and others