Terminal profiles

[meganrogge]

Fixes #45444
Fixes #77652
Fixes #94473

[Tyriar]

Had a quick look

[meganrogge]

Re

I think this needs arg?: string[]?

good find. I don't think we need ITerminalProfileDto bc it is the same as ITerminalProfile, so I've replaced all instances of it

[karlhorky]

@meganrogge @Tyriar I guess the Git Bash profile should probably be like this instead, as per microsoft/vscode-docs#4066:

"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\git-cmd.exe",
"terminal.integrated.shellArgs.windows": [
  "--command=usr/bin/bash.exe",
  "-l",
  "-i"
]

Should I open a new issue for that?

[Tyriar]

@karlhorky yes please 🙂, thanks for checking

[Tyriar]

Created #119346