Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended git bash args in default detected profile #119346

Closed
Tyriar opened this issue Mar 19, 2021 · 3 comments
Closed

Use recommended git bash args in default detected profile #119346

Tyriar opened this issue Mar 19, 2021 · 3 comments
Assignees
Labels
invalid Issue identified as not relevant or not valid terminal Integrated terminal issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 19, 2021

We should use these defaults: https://code.visualstudio.com/docs/editor/integrated-terminal#_windows

Context: #118790 (comment)

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Mar 19, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 19, 2021
meganrogge added a commit that referenced this issue Mar 19, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 19, 2021

We decided against doing this because it seems like git-cmd.exe --command=usr/bin/bash.exe -l -i and bin/bash.exe -l are equivalent and both run .bash_profile which was the original reason it was changed in the docs microsoft/vscode-docs#4066. We'll update the docs this release microsoft/vscode-docs#4406

@Tyriar Tyriar closed this as completed Mar 19, 2021
@Tyriar Tyriar removed this from the March 2021 milestone Mar 19, 2021
@Tyriar Tyriar added invalid Issue identified as not relevant or not valid and removed bug Issue identified by VS Code Team member as probable bug labels Mar 19, 2021
@karlhorky
Copy link

Great, thanks for checking into that (and the simplification)!

@karlhorky
Copy link

By the way, thanks @meganrogge and yourself @Tyriar, now we have simplified the System Setup guide for our bootcamp students with your simplified start command:

upleveled/system-setup@568f3df

@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid Issue identified as not relevant or not valid terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants