-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal profiles #118790
Terminal profiles #118790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look
src/vs/workbench/contrib/terminal/test/node/terminalProfiles.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re
I think this needs arg?: string[]?
good find. I don't think we need ITerminalProfileDto
bc it is the same as ITerminalProfile
, so I've replaced all instances of it
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
1c16f1d
to
cdc9586
Compare
…e filters based on config
@meganrogge @Tyriar I guess the Git Bash profile should probably be like this instead, as per microsoft/vscode-docs#4066:
Should I open a new issue for that? |
@karlhorky yes please 🙂, thanks for checking |
Created #119346 |
Fixes #45444
Fixes #77652
Fixes #94473