Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.json should auto-complete currently used color in color customizations instead of red #119020

Closed
geekley opened this issue Mar 15, 2021 · 4 comments
Assignees

Comments

@geekley
Copy link

geekley commented Mar 15, 2021

In settings.json, when selecting a field for workbench.colorCustomizations or editor.tokenColorCustomizations that has a color value, then auto-completion inserts the red color value automatically #ff0000 so you can replace it with the color you want.
Please make it so it completes with the currently used color for that field, instead of red.

Why?

  1. It's quite difficult to find the currently used color. For example, I wanted to change gitDecoration.modifiedResourceForeground, but I had to look at the source code, and in this case it wasn't obvious that it's actually getting the value from the git extension source, not from the color theme I'm using.
  2. Sometimes you want to make a small adjustment, or an adjustment that would be consistent with the color palette (e.g. change hue while keeping same level of brightness and saturation). For that, you need to know the current value of the color, and it shouldn't be so difficult to find it.
  3. I believe having this practical way of finding out the current value of a color setting would be a great help to color theme developers as well.
@vscodebot
Copy link

vscodebot bot commented Mar 15, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@aeschli
Copy link
Contributor

aeschli commented Mar 15, 2021

I wouldn't change the red code completion, but it would be good to have a hover that shows the current value.

@usernamehw
Copy link
Contributor

Possible duplicate of #25633

I use Developer: Generate Color Theme From Current Settings when searching for color value.

@aeschli
Copy link
Contributor

aeschli commented Mar 16, 2021

Thanks @usernamehw !

Marking as duplicate of #25633

@aeschli aeschli closed this as completed Mar 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants