Use service workers for loading webview resources on desktop #120654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
commented
Apr 6, 2021
.yarnrc
Outdated
| @@ -1,3 +1,3 @@ | |||
| disturl "https://electronjs.org/headers" | |||
| target "11.4.1" | |||
| target "11.4.2" | |||
There was a problem hiding this comment.
@deepak1556 I bumped the electron version for testing but this should likely be part of a separate PR
mjbvz
added a commit
to mjbvz/vscode
that referenced
this pull request
Apr 6, 2021
This brings in the service worker support required for microsoft#120654
deepak1556
pushed a commit
that referenced
this pull request
Apr 7, 2021
* Pick up electorn 11.4.2 This brings in the service worker support required for #120654 * Update cgmanifest
This switches us from using a custom protocol to using a service worker to load resources inside webviews. Previously we had only been using service workers on web (since custom protocols are not supported on web). The service worker based approach is much cleaner to than our custom protocol work and lets us avoid some extra roundtrips between the main process and the renderer We were previously blocked from using service workers on desktop due to an electron issue. However this has now been resolved
mjbvz
force-pushed
the
dev/mjbvz/service-workers-desktop
branch
from
92c97a4
to
ae3aeac
Compare
|
Merging this for testing in insiders It's possible this change will cause regressions due to an oversight the implementation or for specific extensions that are using the webview in interesting ways. Will continue testing today and look for more feedback once this hits insiders |
digitarald
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Pick up electorn 11.4.2 This brings in the service worker support required for #120654 * Update cgmanifest
digitarald
pushed a commit
that referenced
this pull request
Apr 8, 2021
This switches us from using a custom protocol to using a service worker to load resources inside webviews. Previously we had only been using service workers on web (since custom protocols are not supported on web). The service worker based approach is much cleaner to than our custom protocol work and lets us avoid some extra roundtrips between the main process and the renderer We were previously blocked from using service workers on desktop due to an electron issue. However this has now been resolved
mjbvz
added a commit
that referenced
this pull request
Apr 8, 2021
Mistakenly added as part of #120654 Doesn't seem to cause issues in the current builds but breaks our electron 12 build
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Apr 8, 2021
* Pick up electorn 11.4.2 This brings in the service worker support required for microsoft#120654 * Update cgmanifest
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Apr 8, 2021
…ft#120654) This switches us from using a custom protocol to using a service worker to load resources inside webviews. Previously we had only been using service workers on web (since custom protocols are not supported on web). The service worker based approach is much cleaner to than our custom protocol work and lets us avoid some extra roundtrips between the main process and the renderer We were previously blocked from using service workers on desktop due to an electron issue. However this has now been resolved
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Apr 8, 2021
Mistakenly added as part of microsoft#120654 Doesn't seem to cause issues in the current builds but breaks our electron 12 build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches us from using a custom protocol to using a service worker to load resources inside webviews. Previously we had only been using service workers on web (since custom protocols are not supported on web). The service worker based approach is much cleaner to than our custom protocol work and lets us avoid some extra roundtrips between the main process and the renderer
We were previously blocked from using service workers on desktop due to an electron issue. However this has now been resolved
/cc @deepak1556