Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pty host becomes unresponsive when creating a new terminal right after manually relaunching an existing one #121336

Closed
Tyriar opened this issue Apr 14, 2021 · 8 comments · Fixed by #123782
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-conpty Integrated terminal issues related to the ConPTY backend verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2021

Related to #117956

Repro on Windows:

  1. Open a terminal
  2. Type something into it
  3. Toggle the auto attach value, wait for the ⚠️ icon in the terminal
  4. Relaunch the terminal by hovering ⚠️
  5. Create a new terminal

image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 14, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 14, 2021
@Tyriar Tyriar self-assigned this Apr 14, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Apr 14, 2021

Shared process log when this happens:

[IPC Library: Pty Host] TRACE IPty#spawn C:\Program Files\PowerShell\7\pwsh.exe [] {name: "pwsh.exe", cwd: "E:\GitHub\microsoft\vscode-hexeditor", env: {…}, cols: 58, rows: 16, …}
[IPC Library: Pty Host] TRACE IPty#kill
WARN No ptyHost heartbeat after 6 seconds
ERR No ptyHost heartbeat after 12 seconds

@Tyriar
Copy link
Member Author

Tyriar commented Apr 15, 2021

I'm beginning to think this is just another manifestation of #76548

@Tyriar
Copy link
Member Author

Tyriar commented Apr 15, 2021

Yep, the fix for that also fixes this

Tyriar added a commit that referenced this issue Apr 22, 2021
@meganrogge
Copy link
Contributor

meganrogge commented Apr 23, 2021

This actually reproes after any manual relaunch for me ( no need to create a terminal quickly after). Just takes 10 seconds
recording - 2021-04-23T132258 708

@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2021

Things I tried:

  • Throttling spawn calls
  • Throttling kill calls
  • Throttling both spawn and kill calls, ensuring they don't happen near each other
  • Ensure no kill call happens within seconds of process data events

Nothing seemed to fix it. Pushing this to May, I don't think investing more in a mitigation is worth the effort here, we should work on the actual asar fix.

@gganjang
Copy link

gganjang commented May 6, 2021

Re-installing(removed VSCode from windows setting and downloaded stable version(1.56.0) from the website) VSCode worked for me

@markserlin-crucible
Copy link

I am seeing this issue repeatedly
Version: 1.55.2 (user setup)
Commit: 3c4e3df
Date: 2021-04-13T09:35:57.887Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19041

When > 1 terminal window is open either side by side or in separate mode, or indeed on sepearte instances of VSCode.
PS I use the Terminal confgured as a git bash

I believe issue was closed for 1.54.x but see version above

I tried the latest Insider's version and the Terminal dod not open at all - completely broken.
Steps: Menu->Terminal->New Terminal
No response.

@bn3t
Copy link

bn3t commented Jun 3, 2021

I still have on the insider build (updated June 3rd). Terminal works for a while but eventually becomes unresponsive.

Here follows my config for terminal in Windows:

 "terminal.integrated.fontFamily": "Fira Code Retina",
  "terminal.integrated.defaultProfile.windows": "zsh",
  "terminal.integrated.profiles.windows": {
    "zsh": {
      "path": "C:\\cygwin64\\bin\\bash.exe",
      "args": ["-lic", "cd $OLDPWD; exec zsh"]
    },
    "PowerShell -NoProfile": {
      "source": "PowerShell",
      "args": ["-NoProfile"]
    }
  },

@Tyriar Tyriar added the verified Verification succeeded label Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-conpty Integrated terminal issues related to the ConPTY backend verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@bn3t @Tyriar @gganjang @meganrogge @markserlin-crucible and others