-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Often getting full window hangs #71966
Comments
Can you check the Process Explorer? |
Unfortunately it hangs completely -- I can't do anything until it hangs for long enough and I get the |
I haven't seen any hangs in 1.33 so I don't have any ideas about what might be causing it. If it's happening that often, can you keep the dev tools open and try to quickly grab a trace next time it freezes? I will try running compound tasks periodically to see if I can make it happen. |
@alexr00 I was able to get it to hang again with the devtools open |
It usually seems to happen during the following workflow:
Here is my
|
This is happening for me with no special build workflow, just using the integrated terminal to run miscellaneous scripts. Somewhat of a showstopper for someone that uses the integrated terminal heavily. |
I'm having trouble reproducing this via launching 2 tasks in a split terminal, any more details on a repro? 🤔 FYI the get console process list error in #71966 (comment) should be harmless. |
@Tyriar it often takes me a bunch of times trying it, but I can get it to reproduce pretty reliably. I'm using today's insiders ( Here are my terminal settings if that helps any: "terminal.integrated.cursorStyle": "line",
"terminal.integrated.drawBoldTextInBrightColors": false,
"terminal.integrated.fontFamily": "Fira Code Retina",
"terminal.integrated.fontSize": 13,
"terminal.integrated.scrollback": 10000,
"terminal.integrated.shell.windows": "C:\\Program Files\\PowerShell\\6\\pwsh.exe",
"terminal.integrated.windowsEnableConpty": true, I also noticed that it seems more reproducible when there is an existing terminal added to the mix:
I've reproduced it as quickly as 3 iterations of this loop, but sometimes it is more like 6-10 times. EDIT: I've also reproduced this many times with and without all extensions disabled |
Tried with those settings about 30-40 times and couldn't get it to happen. Does running |
It seems to work:
|
Hmm...that told me less than I was hoping 🤔 |
@Tyriar 😞 Is there anything else I can do to help? Not sure how to really debug this. I can screenshare or something if that helps too |
@Tyriar Since yesterday I've been seeing the same hangs, but now by just running my GitLens pack command in the terminal ( |
Now I've seen it a few more times just running |
I added logging to every call in the terminal that goes out to native code. After the next insiders build goes out (1.35.0-insiders), for those seeing the issues could you:
There should be "IPty#..." logs towards the bottom, the last few of those is what I'm interested in. If you can trigger a few times and check the log file to see if it's the same that would also be useful. |
Unfortunately this is going back on the backlog due to issues I had trying to get create workers inside an asar packaged module. More context: #116373 (comment) The good news is that since conpty is now hosted in a separate process, when this hang occurs it will only take down all the terminals and it also gets detected and allows you to recover without a restart: |
Hi @Tyriar, I am able to get the terminal to crash reliably with the following simple Python script on Windows:
I run that script at the terminal by typing "python test_script.py" "intranet_server" is replaced with a server on my intranet and I have set up SSH key authentication with Windows OpenSSH (now included in Windows 10), so the command runs without password prompt. I am able to run the ssh command directly at my VSCode terminal without issue (I see server login messages followed by "Testing ssh call"). However, if I run the Python 3 script above, the terminal will crash shortly after the ssh call. This seems to be an issue with subprocesses exiting after being run under the terminal. The number of lines that get output will vary. When the terminal crashes, the output is corrupted a bit:
Edit: Hmm... I found that by passing shell=True to Python's subprocess.call method, it works without freezing. I don't know what that means. |
If it is of any help
|
Verified after weeks of usage and also no reports |
This brings in microsoft/node-pty#415 which will finally fix the hang issue on Windows with conpty. Performance on Windows should also improve a lot because node-pty is now hosted outside of the cluttered renderer process. Fixes microsoft#71966
Issue Type: Bug
I have been seeing hangs happen on and off since 1.33 was in insiders, but never pinpointed anything. And while I still haven't pinpointed anything the frequency has increased (even at the very end of 1.33). I have noticed that the hangs very often coincide with kicking off a task (usually it is a compound task).
How best can I help capture information to get to the bottom of it? When it happens the window is hung completely so I can't open devtools or anything like that.
VS Code version: Code - Insiders 1.34.0-insider (0ab39f4, 2019-04-08T05:19:58.162Z)
OS version: Windows_NT x64 10.0.18362
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: