-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal pty host unresponsive after closing a VS Code window #117956
Comments
Going to look into whether we can wait for the process input to stop before actually killing the process for windows as another workaround for #71966. This process can take a bit of time now if needed since it's off the window being shutdown which has limited time to react. |
It looks like we are using the same method as before where we indicate to dispose immediate.
Perhaps it's different before because the window going down would more aggressively shut down its child processes? |
@eamodio @meganrogge we can consider bringing this in for the recovery build if we start seeing reports. |
No, a few seconds after I open a second VSCode instance, this error message appears in both instances. It also happens if I open a second terminal in one instance |
@donvanone an extension may be closing the terminal, or it might be getting relaunched if an extension changes the environment (like the git extension will do when opening a new workspace). Does it happen if you open a new window and then wait 10 seconds before opening a terminal, such that extensions can activate? |
I had the problem even with uninstalled extensions. But the good old "did you try turning it off an on again" helped. After a windows reboot, everything works fine |
To clarify the scope of this fix since @eamodio is still seeing lingering issues in insiders for this that we aren't able to nail down. Verified here means that the mechanism to delay killing the process on Windows for up to 5 seconds works as expected. |
Don't know if this helps, but I've noticed that it consistently happens if I open a terminal in 2nd level (is that the vscode term for running vscode "inside" vscode?), after closing that 2nd level all terminals are stuck. |
VSCode 1.55.0, the issue is still there. Single instance of VSCode looks fine, but starting another instance fires the warning almost immediately, breaking terminals in both instances. |
It did not happened with git console but happens a lot with powershell but git has this other problem https://stackoverflow.com/questions/62685569/error-while-installing-python-extensions-cant-open-file-directory-filename . |
I've been getting this recently, though consistently throughout my day, while doing remote ssh sessions through the vscode terminal window. I open a new terminal and then use wsl2, and within wsl2 doing the ssh sessions. I experience this in both of the following VSCode versions: Version: 1.55.1 (user setup) Version: 1.56.0-insider (user setup) |
This pushes the polling for Windows terminal shutdowns into TerminalProcess itself so it's not possible to shutdown a Windows terminal immediately. Part of #117956
for me, even single instanse of vscode show this message, if i want to restart "watch" task |
Update: #121336 (comment) |
Started getting this error in VSCode 1.55.2 after upgrading to Chrome OS v90; appears to cause the whole VM to seize. Persists after full powerwash & fresh VM/Code install, no exts enabled. :( UPDATE: FWIW, I have not experienced the issue on Chrome OS Version 90.0.4430.100 since updating to Code v1.56.0 |
I'm getting this error all the time since some months. If I start an npm script in VS Code this error occurs. So I had to switch to the git bash terminal (Windows). Hope this gets fixed... |
I am receiving this same error myself. I only have a few extensions installed and I've been extremely stable until I installed the PowerShell Extension. At that point I immediately receive the error that "The connection to the terminal's pty host process is unresponsive", as well as two others: "the language service could not be started", and "Loading the PowerShell extension is taking longer than expected. If you're using privilege enforcement software, this can affect start up performance" I'm pretty new to using VS and programming in general so I'm not sure what to do about this. |
@SFeldman-Accenture this should be fixed in the Insiders build as of today, coming to stable in a month or so. |
Hey @Tyriar, forgive me if this is a dumb question but the Insiders build is kind of like a "beta" build? So there's the potential for it to have issues in other areas? Just weighing the pros and cons of getting the extension working vs. potentially having issues in other areas. |
@SFeldman-Accenture yes it is, you may get some instability but also access to new fixes/features. But this issue is fixed (finally), it just won't be available in stable until early next month. |
@SFeldman-Accenture sounds like you have the accessibility mode on, click the "screen reader optimized" button in the status bar. |
I get this all the time even in the Insiders build and with no extensions. It started for me right after updating to macOS Big Sur v11.4 |
@Tyriar I'm getting this issue all the time at Windows10 (so I guess it's not just related to macOS) My system specs are
Any feedback/fix suggestions are greatly appreciated |
@RomanDavlyatshin the new release which fixes this should be out next week. |
I've seen this happen a few times now, and this last time it seemed to happen right after I closed a VS Code window. After that, I got the following notification in all my other open VS Code windows.
Here is the Shared Process output
The text was updated successfully, but these errors were encountered: