Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction breakpoints can not be disabled #129571

Open
isidorn opened this issue Jul 27, 2021 · 3 comments
Open

Instruction breakpoints can not be disabled #129571

isidorn opened this issue Jul 27, 2021 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly feature-request Request for new features or functionality
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 27, 2021

Testing #129161

Found by @yannickowow
@yuehuang010, @xisui-MSFT

  1. Open disassembly view, add instruction breakpoint
  2. Disable instruction breakpoint in the breakpoints view
  3. Disassembly view still shows the breakpoint as enabled 🐛
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 27, 2021
@isidorn isidorn mentioned this issue Jul 27, 2021
2 tasks
@xisui-MSFT
Copy link
Contributor

@yuehuang010 will take a look

@yuehuang010
Copy link
Contributor

Disable and adding Condition for Instruction Breakpoint is a next milestone feature.

@isidorn
Copy link
Contributor Author

isidorn commented Jul 29, 2021

Makes good sense, assigning to August. Let's put feature-request since this is not yet implemented.

@isidorn isidorn added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jul 29, 2021
@isidorn isidorn added this to the August 2021 milestone Jul 29, 2021
@weinand weinand removed their assignment Aug 18, 2021
@isidorn isidorn modified the milestones: August 2021, Backlog Aug 26, 2021
@isidorn isidorn assigned roblourens and unassigned isidorn Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants