Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript kernel tslab] VSCode's intellisense misses variables from blocks that contain "import" statements #130000

Closed
dbuezas opened this issue Aug 1, 2021 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@dbuezas
Copy link

dbuezas commented Aug 1, 2021

Environment data

  • VS Code version: Version: 1.58.2 (Universal)
  • Jupyter Extension version: v2021.8.1054968649
  • Python Extension version: Not installed
  • OS: Mac 11.5.1 (20G80)
  • Python and/or Anaconda version: conda 4.10.3
  • Type of virtual environment used: N/A
  • Jupyter server running: Local

Expected behaviour

  • Imports from previous blocks are visible in following ones
  • Variables declared in previous blocks are visible in following ones (also if there is an import statement in the previous block)

Actual behaviour

image

Steps to reproduce:

  1. Install this Jupyter extension
  2. Install Jupyter Lab, tslab, add it as a kernel
  3. Create a new notebook
  4. in block 1: import something in block 1 and declare a variable
  5. in block 2: refer to either the declared variable or imported module

Logs

Not applicable

@dbuezas
Copy link
Author

dbuezas commented Aug 1, 2021

Also reported here: yunabe/tslab#56 with some nasty workarounds

@DavidKutu
Copy link

Thanks for reporting @dbuezas. I'll bring it up in a triage meeting

@roblourens
Copy link
Member

@mjbvz has there been any discussion about js/ts language support in notebooks or is this out-of-scope for the time being?

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 14, 2021

Duplicate of #129482

@mjbvz mjbvz marked this as a duplicate of #129482 Oct 14, 2021
@mjbvz mjbvz closed this as completed Oct 14, 2021
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants