Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Bracket Pair Colorization #131416

Closed
2 tasks done
hediet opened this issue Aug 23, 2021 · 2 comments
Closed
2 tasks done

Test Bracket Pair Colorization #131416

hediet opened this issue Aug 23, 2021 · 2 comments
Assignees
Labels
testplan-item verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Aug 23, 2021

Refs: #128465

Complexity: 3

Create Issue


Preparation

  • Enable bracket pair colorization (currently enabled by default, will change on 25/08): "editor.bracketPairColorization.enabled": true.

Tasks

  • Verify bracket pair colorization is correct, in particular after complex edits and when brackets appear in comments or strings
  • Verify that unclosed bracket pairs get closed automatically when a parent bracket pair is closed: (]) vs [(])
  • Verify that closing brackets that have no opening bracket pair are highlighted red.
  • Verify that colors can be customized and new colors can be added (up to 6):
    "workbench.colorCustomizations": {
        "editorBracketHighlight.foreground1": "#FFD700",
        "editorBracketHighlight.foreground2": "#DA70D6",
        "editorBracketHighlight.foreground3": "#87CEFA",
        // ...
    },
  • Verify that bracket pair colorization adds no noticable delay for medium-sized files.
@ghost ghost assigned DonJayamanne and alexr00 Aug 24, 2021
@alexr00 alexr00 removed their assignment Aug 24, 2021
@alexr00 alexr00 added this to the August 2021 milestone Aug 24, 2021
@DonJayamanne
Copy link
Contributor

time to un-install the extension from he marketplace that already does this.

@DonJayamanne
Copy link
Contributor

Works perfectly well, one less extension

@DonJayamanne DonJayamanne added the verified Verification succeeded label Aug 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants