Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybinding widget: treat "unknown" special? #1372

Closed
bpasero opened this issue Dec 16, 2015 · 1 comment
Closed

Keybinding widget: treat "unknown" special? #1372

bpasero opened this issue Dec 16, 2015 · 1 comment
Assignees
@alexdima
Milestone
Feb 2016

Comments

@bpasero
Copy link
Member

bpasero commented Dec 16, 2015

When I type a key that results in "unknown" I suggest to show a warning message in the widget and let it not dismiss on Enter. currently you get 2 times unknown in the widget (one in the input field and one for the label).
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2015
@bpasero bpasero added this to the Backlog milestone Dec 16, 2015
@AntonAderum AntonAderum mentioned this issue Jan 5, 2016
Closed
@alexdima alexdima modified the milestones: Feb 2016, Backlog Feb 2, 2016
@alexdima
Copy link
Member

Will leave as unknown, the good part is we get issues filed with folks asking for more supported keys due to it.

@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Jul 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@bpasero @alexdima