Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: refactored hex editor #138092

Closed
2 tasks done
connor4312 opened this issue Nov 29, 2021 · 0 comments
Closed
2 tasks done

Test: refactored hex editor #138092

connor4312 opened this issue Nov 29, 2021 · 0 comments

Comments

@connor4312
Copy link
Member

connor4312 commented Nov 29, 2021

Ref #15756

Complexity: 5

Authors: @connor4312, @lramos15

Create Issue


As part of support for debugger memory, we wanted to refactor the hex editor to support arbitrarily large files. This was a significant set of changes. While we still use extension host APIs which only support reading entire files into memory, the infrastructure is there to remove this restriction and add use cases and we focused on reaching parity with the previous version of the hex editor.

Therefore, please go through the hex editors and verify everything works using this vsix:
hexeditor-1.8.2.vsix.zip

  • Viewing of bytes and scrolling works
  • Navigation works via keyboard
  • Selections work. Selections can be added/altered with modifier keys
  • Editing bytes work. Edits should be shown with a diff background (blue by default) while unsaved
  • Undo/redo works
  • Find works (ctrl/cmd+F for the widget as usual). The total number of results is limited to 10k by default, but can be increased by clicking the result number.
  • Find and replace works
  • The data inspector works
  • The "Hex Editor: Go to Offset" command works
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants