Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Also modified elsewhere' indicator looks off #153574

Closed
mjbvz opened this issue Jun 28, 2022 · 0 comments · Fixed by #153621
Closed

'Also modified elsewhere' indicator looks off #153574

mjbvz opened this issue Jun 28, 2022 · 0 comments · Fixed by #153621
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
June 2022

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 28, 2022 •
edited

Testing #153351

Screen Shot 2022-06-28 at 11 19 31 AM

This indicator looks strange to me for a few reasons:

  • There is a mix of italic text with a non-italic icon
  • The text isn't centered with the icon
  • The icon is can be brighter than the rest of the text:

Screen Shot 2022-06-28 at 11 26 19 AM
@rzhao271 rzhao271 added this to the June 2022 milestone Jun 28, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jun 28, 2022
rzhao271 added a commit that referenced this issue Jun 28, 2022
@rzhao271
Fixes #153578, #153576, #153420, #153574, #153586
71d268a 
- Remove info icons
- Add underline when hovering over indicators
- Handle sync ignored hover properly
@rzhao271 rzhao271 mentioned this issue Jun 28, 2022
Merged
rzhao271 added a commit that referenced this issue Jun 29, 2022
@rzhao271
Remove info icons from Settings editor indicators + other small fixes (…
db56bde 
…#153621)

Fixes #153578
Fixes #153576 
Fixes #153420 
Fixes #153574 
Fixes #153586
Fixes #153638
- Remove info icons
- Add underline when hovering over indicators
- Handle sync ignored hover properly
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 29, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Remove info icons from Settings editor indicators + other small fixes microsoft/vscode
4 participants
@rzhao271 @mjbvz @joyceerhl @VSCodeTriageBot