Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focused item in settings makes the modified icon not visible #153586

Closed
isidorn opened this issue Jun 28, 2022 · 1 comment · Fixed by #153621
Closed

Focused item in settings makes the modified icon not visible #153586

isidorn opened this issue Jun 28, 2022 · 1 comment · Fixed by #153621
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
June 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2022

Testing #153351

Focus on an item in the settings editor. Notice that the i icon is not visible due to bad contrast

Screenshot 2022-06-28 at 20 42 25
@isidorn isidorn added the settings-editor VS Code settings editor issues label Jun 28, 2022
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2022
@rzhao271 rzhao271 added this to the July 2022 milestone Jun 28, 2022
rzhao271 added a commit that referenced this issue Jun 28, 2022
@rzhao271
Fixes #153578, #153576, #153420, #153574, #153586
71d268a 
- Remove info icons
- Add underline when hovering over indicators
- Handle sync ignored hover properly
@rzhao271 rzhao271 modified the milestones: July 2022, June 2022 Jun 28, 2022
@rzhao271 rzhao271 mentioned this issue Jun 28, 2022
Merged
rzhao271 added a commit that referenced this issue Jun 29, 2022
@rzhao271
Remove info icons from Settings editor indicators + other small fixes (…
db56bde 
…#153621)

Fixes #153578
Fixes #153576 
Fixes #153420 
Fixes #153574 
Fixes #153586
Fixes #153638
- Remove info icons
- Add underline when hovering over indicators
- Handle sync ignored hover properly
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 29, 2022
@isidorn isidorn added the verified Verification succeeded label Jun 30, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Jun 30, 2022

Icon is no longer there, which is fine for me -> verified.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Remove info icons from Settings editor indicators + other small fixes microsoft/vscode
3 participants
@isidorn @rzhao271 @VSCodeTriageBot