-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension contributed submenus missing with errors in output #155030
Comments
@jrieken could this be a consequence of your recent work on menus? |
Yes. Menu identifiers need to be unique (while they were using a different identity before). I think for contributed submenus this needs to be relaxed |
The error mentions a different menu identifier ( |
@jrieken I'm still able to reproduce this on the latest insiders version.
Version: 1.70.0-insider |
According to @fiveisprime this still repros |
/needsMoreInfo
Please update your steps and sample so that we can reproduce this |
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue. Happy Coding! |
Still investigating this issue, it seems to be related to submenu merging. |
Let's assign to August for an investigation. |
Since this looks like a regression - marking as a candidate for recovery release 2. |
Created a PR #158140 fixing this |
@jeanp413 awesome, thanks a lot! @alexweininger we expect to have a stable release on Wednesday that will have a fix for this issue. Thanks and sorry about the breakage! |
Fix is in |
@alexweininger Can you please verify this with latest insiders and/or 1.70.2 release candidate |
Verified with latest insiders. Version: 1.71.0-insider |
Does this issue occur when all extensions are disabled?: No
VS Code version info
Version: 1.70.0-insider
Commit: 052d5b0
Date: 2022-07-13T05:21:34.551Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin x64 21.5.0
The Azure Resource Groups extension has a submenus that aren't showing up on Insiders, but show up as expected on VS Code Stable. microsoft/vscode-azureresourcegroups#330
The issue only reproduces on insiders 1.70.0-insider. Does not repro on stable (1.69.1)
I've verified that this bug impacts GitLens submenus as well, but haven't had time to log the issue over there yet.
I've made a sample extension as a minimal reproduction. https://github.com/alexweininger/vscode-submenu-sample
Steps to Reproduce:
editor/title
.I believe it could be caused by
21147b8
(#154801)Errors from the "Log (Window)" output channel:
Screen.Recording.2022-07-13.at.12.25.59.AM.mov
You can also easily reproduce this by installing and enabled/disabling various extensions that contribute submenus. Ex: GitLens and Azure Resource Groups.
The text was updated successfully, but these errors were encountered: