Include @types from typings

[sant123]

• VSCode Version: 1.7.2
• OS Version: Windows 8.1

Steps to Reproduce:

1. Download oracledb npm i oracledb
2. Init a package.json
3. Asign a type with jsdoc into a var

/** @type { IConnectionAttributes } */
var config = require("./config");

You can notice there's no intellisense with this interface from oracledb typings.

interface IConnectionAttributes {
    user?: string;
    password?: string;
    connectString: string;
    stmtCacheSize?: number;
    externalAuth?: boolean;
    /** If not passed, "default" will be used. */
    poolAlias?: string;
}

[mjbvz]

Thanks for the report. Do you notice this problem with any other packages (oracledb is a pain to install and seems to require me registering with oracle in order to get the "Oracle Instant Client")

Also, do you import IConnectionAttributes? TypeScript will not pick up the types unless you do this. Here's what I did for express:

import express from 'express'

/**
 * @type {express.Application}
 */
var app;

[sant123]

@mjbvz thanks to you for answering. 😄 Sure, I've tested with express and it works as expected according with your example, however it only works with ES2015 import/export feature, but not with Common.js. Running this code will raise an exception.

Here I show you the behavior with Common.js against ES2015.

[mjbvz]

After looking at this again, this looks like a duplicate of microsoft/TypeScript#11825 or microsoft/TypeScript#14056 We're tracking these on the TypeScript side.

As you noted, the workaround currently is to use an import pattern instead of var x = require(...)

[MicahZoltu]

Unfortunately, using the import pattern only works if you are writing (or transpiling from) ES2015. I have been unable to find a workaround that works with ES5.