Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Machine id of a session from insiders.vscode.dev is shown as undefined #161935

Closed
sandy081 opened this issue Sep 27, 2022 · 3 comments
Closed

Machine id of a session from insiders.vscode.dev is shown as undefined #161935

sandy081 opened this issue Sep 27, 2022 · 3 comments
Assignees
@joyceerhl
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2022

Comments

@sandy081
Copy link
Member

Testing #161860

  • I have opened VS Code repo in VS Code Desktop and insiders.vscode.dev
  • Stored some edit sessions
    🐛 Those sessions from insiders.vscode.dev are shown with undefined machine id

image
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Sep 27, 2022
@joyceerhl joyceerhl added this to the September 2022 milestone Sep 27, 2022
@joyceerhl
Copy link
Contributor

That is really odd, I cannot repro...are you on the latest insiders build for insiders.vscode.dev?
image

@joyceerhl
Copy link
Contributor

Regardless I think I have a fix for this.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 28, 2022
@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Sep 30, 2022
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@sandy081, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version bcb6c9b of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@mjbvz mjbvz added the verified Verification succeeded label Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

No branches or pull requests
5 participants
@roblourens @sandy081 @mjbvz @joyceerhl @vscodenpa