Reduce unused exports #164934
Comments
|
Just because something isn't used by anyone, it doesn't mean it should not be exported, since someone might need to import it. Especially types that are referenced in exported public methods should IMHO remain exported. Not so long ago, TS would even give a compile error if a public exported member was referencing a non-exported type. For example, // callback is inlined, there's no need to name its type
monitor.startMonitoring(..., (event: PointerEvent) => { /* do something */ }, ...);But a user of this class might want to write this kind of code: // callback is not inlined, maybe its type needs to be referred explicitly
const moveCallback: IPointerMoveCallback = (event: PointerEvent) => { /* do something */ };
monitor.startMonitoring(..., moveCallback, ...);Another example, this._register(textArea.onCompositionStart((e) => { /* do something */ }));But a user might want to extract the event handler to a method: this._register(textArea.onCompositionStart((e) => this._onCompositionStart(e)));
// ...
private _onCompositionStart(e: ICompositionStartEvent) { /* do something */ }A third example, const guessedIndentation = guessIndentation(textBuffer, options.tabSize, options.insertSpaces);But a user might want to extract the code to a method and they would want to use the type. |
* Fixes #164934: Only export symbols that are needed * `KeyMod` is referenced by `monaco.d.ts`
vscodenpa
added
the
unreleased
vscodenpa
added
insiders-released
@rebornix and I were wondering if there is any dead code in the VS Code codebase, and one idea was to detect unused exports across the codebase, since unused variables are flagged by the compiler but unused exports are not.
I ran
ts-unused-exportson our sources and generated the following list. I've already done a pass to remove some false positives but apologies if several remain. From a quick sanity check, several of these are indeed not used outside of the file they are declared in and do not need to be exported. Please feel free to close if you find that this isn't valuable.IPointerMoveCallbackIOnStopCallbackAbstractScrollbarOptionsAbstractScrollableElementKeyLabelProviderModifierLabelProviderScrollStateISmoothScrollPositionIScrollableOptionsIAnimationIRequestHandlerFactorycreateNodeSocketCloseEventWebSocketCloseEventSocketTimeoutEventRequestTypeResponseTypeIChannelServerIRoutingChannelClientRequestInitiatorlogWithColorsIMouseWheelEventCtorbeginTrackingDisposablesendTrackingDisposablesbeginLoggingFSendLoggingFStestRepeatTokeneditorinitializeICommandKeybindingsOptionsCommandImplementationIContributionCommandOptionsEditorControllerCommandEditorActionImplementationISerializedFontInfoISettingsReadershadowCaretRangeFromPointClipboardStoredMetadataICompositionStartEventModelTransientSettingWatcherRefCountedStyleSheetIMouseDispatchDataViewOverlaysViewOverlayLineEventCallbackAbstractLineHighlightOverlayIMinimapModelRevealTargetCharacterMapMultipleCharacterMapcachedStringRepeatIEditorZoomCursorPositionIDiffComputerResultUint8MatrixEditorModesRegistryIReducedTokenizationSupportThemeTrieElementIGuessedIndentationLONG_LINE_BOUNDARYIDecorationsTreesHostDidChangeDecorationsEmitterDidChangeContentEmitterKeyModIRawModelDataMirrorModelIForeignModuleFactorycreateID_EDITOR_WORKER_SERVICEDocumentSemanticTokensResultIResolvedLanguageEditStackPastFutureElementsILineSequenceModelSemanticColoringSemanticTokensProviderStylingConstantsSparseLineTokensRenderWhitespaceCharacterMappingConstantsRenderLineOutputIDecorationsViewportDataColorHoverIPreflightDataSupportedIPreflightDataUnsupportedTestFindControllerClickLinkOptionsHoverResultMarkerHoverInlineCompletionsHoverIGlobalEditorOptionsStandaloneCodeEditorcreateonDidCreateEditoronDidCreateDiffEditorgetEditorsgetDiffEditorscreateDiffEditorIDiffNavigatorOptionsICommandDescriptoraddCommandaddEditorActionIKeybindingRuleaddKeybindingRuleaddKeybindingRulescreateModelsetModelLanguagesetModelMarkersremoveAllMarkersonDidChangeMarkersgetModelsonDidCreateModelonWillDisposeModelcreateWebWorkercolorizeElementcolorizecolorizeModelLinetokenizeremeasureFontsregisterCommandgetLanguagesEncodedTokenizationSupportAdapterTokensProviderFactorysetColorMapregisterTokensProviderFactorysetTokensProvidersetMonarchTokensProviderregisterReferenceProviderregisterRenameProviderregisterSignatureHelpProviderregisterHoverProviderregisterDocumentSymbolProviderregisterDocumentHighlightProviderregisterLinkedEditingRangeProviderregisterDefinitionProviderregisterImplementationProviderregisterTypeDefinitionProviderregisterCodeLensProviderregisterCodeActionProviderregisterDocumentFormattingEditProviderregisterDocumentRangeFormattingEditProviderregisterOnTypeFormattingEditProviderregisterLinkProviderregisterCompletionItemProviderregisterColorProviderregisterFoldingRangeProviderregisterDeclarationProviderregisterSelectionRangeProviderregisterDocumentSemanticTokensProviderregisterDocumentRangeSemanticTokensProviderregisterInlineCompletionsProviderregisterInlayHintsProviderCodeActionProviderCodeActionProviderMetadataIKeybindingRuleEditorScopedQuickInputServiceIShortMonarchLanguageRule1IShortMonarchLanguageRule2IExpandedMonarchLanguageRuleIMonarchLanguageRuleIShortMonarchLanguageActionIExpandedMonarchLanguageActionIMonarchLanguageActionTestCodeEditorCreationOptionscreateSingleEditOpcreateSingleEditOpMockTextAreaWrappertestTextBufferFactorygenerateRandomEditsgenerateSequentialInsertsgenerateRandomReplacesIContextKeyExpressionContextKeyFalseExprContextKeyTrueExprContextKeyNotRegexExprITranslationIWindowsKeyMappingILinuxKeyMappingILinuxKeyboardMappingIMacKeyMappingIMacKeyboardMappingIWebSocketCloseEventIWebSocketdefaultWebSocketFactoryAuthRequestOKMessageConnectionLostEventReconnectionRunningEventConnectionGainEventReconnectionPermanentFailureEventExtensionHostPersistentConnectionURIDescriptorfontStylePatternBaseTunnelServiceRemoteExtensionHostAgentServerIExtensionsManagementProcessInitDataprintTimespawnClicreateServerNoneServerConnectionTokenOptionalServerConnectionTokenMandatoryServerConnectionTokengetWordDefinitionForFailedExtensionDocumentSemanticTokensAdapterDocumentRangeSemanticTokensAdapterstartExtensionHostProcesscreatecreateIResourceCreatorInsertSnippetResultRangeHighlightDecorationsScrollPositionITerminalEnvironmentVariableCollectionsConfigurationEditingErrorIExtHostNamedCustomerIExtHostCustomerCtorDeltaExtensionsResultExtHostConnectionExtensionHostStartupClassificationExtensionHostStartupEventMessagePortLikeIResolveAuthorityOKResultJSONStringifyReplacerIExtensionActivationResultNativeResolvedKeybindingIScanCodeMappingcreateRemoteAgentConnectionIValidGrammarDefinitionDTOICreateDataIRawModelDatacreateIEmbeddedLanguagesMapIColorThemeITokenColorizationRuleITokenColorizationSettingassertCleanStateThe text was updated successfully, but these errors were encountered: