Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+c in terminal does not scroll to the very bottom when smooth scroll is enabled #211199

Closed
Tyriar opened this issue Apr 24, 2024 · 2 comments · Fixed by #221500
Closed

Ctrl+c in terminal does not scroll to the very bottom when smooth scroll is enabled #211199

Tyriar opened this issue Apr 24, 2024 · 2 comments · Fixed by #221500
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
July 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2024 •
edited
Loading

Repro:

  1. Fill viewport
  2. Scroll up
  3. Press ctrl+c, 🐛 the terminal is not scrolled to the very bottom

Recording 2024-04-23 at 17 51 44
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 24, 2024
@Tyriar Tyriar added this to the April 2024 milestone Apr 24, 2024
@Tyriar Tyriar self-assigned this Apr 24, 2024
@Tyriar Tyriar added the papercut 🩸 A particularly annoying issue impacting someone on the team label Apr 24, 2024
@Tyriar Tyriar modified the milestones: April 2024, May 2024 Apr 24, 2024
@Tyriar
Copy link
Member Author

Tyriar commented May 1, 2024

This is a bug when "terminal.integrated.smoothScrolling": true is set

@Tyriar Tyriar modified the milestones: May 2024, Backlog May 1, 2024
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream and removed papercut 🩸 A particularly annoying issue impacting someone on the team labels May 1, 2024
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 11, 2024
@Tyriar
Scroll immediately to bottom when scrollOnUserInput is enabled
90a1da2 
See microsoft/vscode#211199
@Tyriar Tyriar modified the milestones: Backlog, July 2024 Jul 11, 2024
@Tyriar Tyriar added upstream-issue-fixed The underlying upstream issue has been fixed papercut 🩸 A particularly annoying issue impacting someone on the team labels Jul 11, 2024
@Tyriar Tyriar mentioned this issue Jul 11, 2024
Merged
6 tasks
Tyriar added a commit that referenced this issue Jul 11, 2024
@Tyriar
Update xterm and integrate new scroll bars
4f13098 
Fixes #211199
Fixes #216521
See xtermjs/xterm.js#5096
@Tyriar Tyriar mentioned this issue Jul 11, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 11, 2024
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jul 24, 2024
@Tyriar Tyriar changed the title Ctrl+c in terminal does not scroll to the very bottom Ctrl+c in terminal does not scroll to the very bottom when smooth scroll is enabled Jul 29, 2024
@Leonikkk
Copy link

Leonikkk commented Aug 3, 2024

Gzt

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Update xterm and integrate new scroll bars microsoft/vscode
4 participants
@Tyriar @eleanorjboyd @vscodenpa @Leonikkk