Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: Enabling typescript esModuleInterop #212977

Closed
SimonSiefke opened this issue May 17, 2024 · 1 comment
Closed

feature request: Enabling typescript esModuleInterop #212977

SimonSiefke opened this issue May 17, 2024 · 1 comment
Assignees
@mjbvz

Comments

@SimonSiefke
Copy link
Contributor

As suggested by @jrieken in #212727, it seems it would be useful to enable typescript esModuleInterop to make imports ESM compatible.

For enabling it, it seems these changes would be needed:

  • Enabling the option in tsconfig.json
  • Changing import * as assert from 'assert' to import assert from 'assert' (~600 changes)
  • Changing some other imports
@SimonSiefke SimonSiefke mentioned this issue May 18, 2024
Closed
@SimonSiefke
Copy link
Contributor Author

Fixed by #214144

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjbvz @SimonSiefke