Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessible view go to symbol is not showing #212994

Open
meganrogge opened this issue May 17, 2024 · 3 comments
Open

accessible view go to symbol is not showing #212994

meganrogge opened this issue May 17, 2024 · 3 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug debt Code quality issues

Comments

@meganrogge
Copy link
Contributor

  1. focus a chat response
  2. use alt+f2 with screen reader mode enabled
  3. use ctrlCmd+shift+o to go to symbol
  4. 🐛 it doesn't work
@meganrogge meganrogge self-assigned this May 17, 2024
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels May 17, 2024
@meganrogge meganrogge added this to the May 2024 milestone May 17, 2024
@meganrogge
Copy link
Contributor Author

need to port the terminal accessibility help over to using the new accessible view registry

it's returning here bc it's not an instance of AdvancedContentProvider

const provider = this._currentProvider instanceof AdvancedContentProvider ? this._currentProvider : undefined;

@meganrogge
Copy link
Contributor Author

getProvider is not async, so this would be a bit involved

AccessibleViewRegistry.register({
	type: AccessibleViewType.Help,
	priority: 105,
	name: 'terminal',
	getProvider: (accessor) => {
		const instantiationService = accessor.get(IInstantiationService);
		const terminalService = accessor.get(ITerminalService);
		terminalService.getActiveOrCreateInstance().then(async instance => {
			await terminalService.revealActiveTerminal();
			const terminal = instance?.xterm;
			if (!terminal) {
				return;
			}
			return instantiationService.createInstance(TerminalAccessibilityHelpProvider, instance, terminal);
		});
	}
});

@meganrogge meganrogge modified the milestones: May 2024, June 2024 May 21, 2024
@meganrogge meganrogge modified the milestones: June 2024, July 2024 Jun 19, 2024
@meganrogge meganrogge added the debt Code quality issues label Jul 12, 2024
@meganrogge
Copy link
Contributor Author

we can now use onDidChangeContent, so this should be doable

@meganrogge meganrogge modified the milestones: July 2024, August 2024 Jul 12, 2024
@meganrogge meganrogge removed this from the August 2024 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug debt Code quality issues
Projects
None yet
Development

No branches or pull requests

1 participant