Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to remote via ssh is broken in v1.90 #214462

Closed
kolyalan opened this issue Jun 6, 2024 · 20 comments · Fixed by #221259
Closed

Connecting to remote via ssh is broken in v1.90 #214462

kolyalan opened this issue Jun 6, 2024 · 20 comments · Fixed by #221259
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug electron-29-update insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken remote Remote system operations issues verified Verification succeeded
Milestone

Comments

@kolyalan
Copy link

kolyalan commented Jun 6, 2024

Type: Bug

My setup is raspberry pi 4 model B with Raspbian GNU/Linux 10 (buster). I am trying to connect from windows system on local network.
Connection via ssh now prints the following

[16:06:31.320] [server] server inflate progress: 1375/1689 (81%)
[16:06:31.364] [server] server inflate progress: 1461/1689 (87%)
[16:06:31.439] [server] server inflate progress: 1547/1689 (92%)
[16:06:31.474] [server] server inflate progress: 1633/1689 (97%)
[16:06:31.496] [server] server inflate progress: 1689/1689 (100%)
[16:06:31.540] [server] Error installing server: error checking server integrity: failed to run command "/home/pi/.vscode-server/cli/servers/Stable-89de5a8d4d6205e5b11647eb6a74844ca23d2573.staging/server/bin/code-server --version" (code 1): /home/pi/.vscode-server/cli/servers/Stable-89de5a8d4d6205e5b11647eb6a74844ca23d2573.staging/server/node: /usr/lib/arm-linux-gnueabihf/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /home/pi/.vscode-server/cli/servers/Stable-89de5a8d4d6205e5b11647eb6a74844ca23d2573.staging/server/node)

[16:06:34.106] Password dialog canceled
[16:06:34.106] "install" terminal command canceled
[16:06:34.106] Resolver error: Error: Connecting was canceled

I tried downgrading vscode on windows to 1.89.1 and connection worked again.

VS Code version: Code 1.90.0 (89de5a8, 2024-06-04T19:33:54.889Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Connection to 'SSH: raspi-18' could not be established Connecting was canceled

Extensions: none

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
jchc7451:31067544
chatpanelt:31048053
dsvsc021:30996838
0ee40948:31013168
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
pythonprt:31056678
dwnewjupyter:31046869
newcmakeconfigv2:31067619
26j00206:31048877

@connor4312
Copy link
Member

@deepak1556 currently non-legacy glibc++ support is set at 3.4.25, did we bump it in the last release?

@deepak1556
Copy link
Collaborator

deepak1556 commented Jun 7, 2024

No we haven't bumped the sysroots, but seems like an issue in the node binary pipeline for armhf specifically, haven't seen reports for arm64 or x86_64. I will take a look.

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues regression Something that used to work is now broken electron-29-update labels Jun 7, 2024
@deepak1556
Copy link
Collaborator

Sorry misread the logs, the issue is not with legacy but the default server which is something downloaded from upstream and not built by us. The symbol verification check in CI didn't scan the node binary which missed this signal early

# Get all files with .node extension from remote/node_modules folder
files=$(find remote/node_modules -name "*.node" -not -path "*prebuilds*")

Both x86_64 and arm64 requirements have not changed, but armhf GLIBCXX is now bumped to 3.4.26. We should bump our checks so that legacy server is used for this case. Thoughts ?

@iqnite
Copy link

iqnite commented Jun 8, 2024

Is there any workaround to connect via VS Code Remote SSH until the bug is fixed?

@JudaV
Copy link

JudaV commented Jun 9, 2024

Same on MacOS. Best workaround seems downgrading to the april version.

@iqnite
Copy link

iqnite commented Jun 10, 2024

Same on MacOS. Best workaround seems downgrading to the april version.

Any other workaround? Is there a way to skip the integrity check? Because even after I downgrade, VS Code will automatically download the new version...
Also, will the fix be in 1.90.1 or 1.91?

@JudaV
Copy link

JudaV commented Jun 10, 2024

First turn off auto-update, then downgrade to previous version.

@jedpop
Copy link

jedpop commented Jun 10, 2024

Same on MacOS. Best workaround seems downgrading to the april version.

Any other workaround? Is there a way to skip the integrity check? Because even after I downgrade, VS Code will automatically download the new version... Also, will the fix be in 1.90.1 or 1.91?

I can confirm that uninstalling 1.90 and then installing 1.89.1 allowed connecting using SSH to my Pi 3B+.

Plus, I disabled updates here to avoid automatic updates:
image

@debemdeboas
Copy link

Same on MacOS. Best workaround seems downgrading to the april version.

Any other workaround? Is there a way to skip the integrity check? Because even after I downgrade, VS Code will automatically download the new version... Also, will the fix be in 1.90.1 or 1.91?

I can confirm that uninstalling 1.90 and then installing 1.89.1 allowed connecting using SSH to my Pi 3B+.

Plus, I disabled updates here to avoid automatic updates: image

Uninstalling 1.90 and installing 1.89.1 didn't fix our issues, and only with 1.80.2 does the problem seem to be less present, but still there sometimes.

@dchstudios
Copy link

Glad I found this thread! First turn Off the Updates as shown above Before you downgrade (as it will just auto immediate upgrade to the broken again). I then reinstalled back to VSC 1.88.1, now the SSH to my RPi4 works again, phew!! What a pain though, after 2 days of trying to figure out wth went wrong.

@JayNaire
Copy link

If you have Ubuntu snap intallation of code (snap list to check ) you may also need
sudo snap refresh --hold=forever code

@jaqarrick
Copy link

Following this.

@JudaV
Copy link

JudaV commented Jul 4, 2024

Bug still present in June 2024 (version 1.91). After updating I can not connect to my raspberry pi 4:

Failed to connect to the remote extension host server (Error: WrappedError(WrappedError { message: "error checking server integrity", original: "failed to run command "/home/pi/.vscode-server/cli/servers/Stable-ea1445cc7016315d0f5728f8e8b12a45dc0a7286.staging/server/bin/code-server --version" (code 1): /home/pi/.vscode-server/cli/servers/Stable-ea1445cc7016315d0f5728f8e8b12a45dc0a7286.staging/server/node: /usr/lib/arm-linux-gnueabihf/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /home/pi/.vscode-server/cli/servers/Stable-ea1445cc7016315d0f5728f8e8b12a45dc0a7286.staging/server/node)\n" }))

@iqnite
Copy link

iqnite commented Jul 4, 2024

Imagine Microsoft messed up one of the biggest features of the world's best 1 code editor because they forgot to increment a version number...

@debemdeboas
Copy link

How hasn't this been assigned higher priority? Remote SSH is central to our workflow, and I believe most of yours as well...

@jedpop
Copy link

jedpop commented Jul 5, 2024

Same on MacOS. Best workaround seems downgrading to the april version.

Any other workaround? Is there a way to skip the integrity check? Because even after I downgrade, VS Code will automatically download the new version... Also, will the fix be in 1.90.1 or 1.91?

I can confirm that uninstalling 1.90 and then installing 1.89.1 allowed connecting using SSH to my Pi 3B+.

Plus, I disabled updates here to avoid automatic updates: image

FYI: The settings seem to only work when the installation was done with "user setup" (the installation I used). An intern installed using "system setup" (as I understand) and found that "system setup" will continue to update VS Code regardless of these settings. They uninstalled the system setup and used user setup during install and the automatic update obeyed the settings...

You can check the installation by going to Help, About:
image
^- This shows my installation as "user setup"...which I find obeys the aforementioned settings...

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 9, 2024
@vscodenpa vscodenpa added this to the July 2024 milestone Jul 9, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 10, 2024
@deepak1556 deepak1556 added the author-verification-requested Issues potentially verifiable by issue author label Jul 10, 2024
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@kolyalan, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 8703a11 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@Sennevds
Copy link

/verified

@JudaV
Copy link

JudaV commented Jul 11, 2024

Working as expected again in the Insiders Build. Thank you @deepak1556

@thisdotmatt
Copy link

/verified

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug electron-29-update insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken remote Remote system operations issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.