Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differences in Terminal and Editor font rendering on Windows #35991

Closed
chrmarti opened this issue Oct 10, 2017 · 19 comments
Closed

Differences in Terminal and Editor font rendering on Windows #35991

chrmarti opened this issue Oct 10, 2017 · 19 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
September Recover...

Comments

@chrmarti
Copy link
Contributor

  • VSCode Version: Code 1.17.1 (1e9d365, 2017-10-10T14:24:50.851Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions: Some

1.17.1 candidate build

Using the steps from #35188 with Fira Code on my Windows 10 VM:
image

The terminal's rendering seems to have less weight?
@chrmarti chrmarti added the terminal Integrated terminal issues label Oct 10, 2017
@wsmd
Copy link

wsmd commented Oct 10, 2017

I'm having similar issue with Version 1.17.1 (1.17.1) on macOS Sierra 10.12.6

The terminal font looks a little bit blurry and squeezed compared to the editor font:

"terminal.integrated.fontFamily": "Menlo",
"terminal.integrated.lineHeight": 1.4,

Terminal

image

Editor

image

@skriss
Copy link

skriss commented Oct 10, 2017

I'm also seeing this issue on the same configuration as @wsmd

@abrakidabra
Copy link

abrakidabra commented Oct 11, 2017 •
edited

I'm having the same issue. Only in the latest version though. This wasn't a problem for me in v1.17.

macOS 10.12.6
VS Code v1.17.1

screen shot 2017-10-11 at 13 19 38

screen shot 2017-10-11 at 13 19 00

Edit: Should have mentioned I'm on the 2012 Macbook Pro Non-retina model. Screen resolution is 1440x900.

@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2017

Can repro on a low DPI monitor (well VM).

@ivan-ha ivan-ha mentioned this issue Oct 11, 2017
Closed
@ivan-ha
Copy link

ivan-ha commented Oct 11, 2017

facing the same after update to 1.17.1 on macOS

@Tyriar Tyriar mentioned this issue Oct 11, 2017
Closed
@Tyriar Tyriar added this to the October 2017 milestone Oct 11, 2017
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Oct 11, 2017
@Tyriar Tyriar closed this as completed in 2b99699 Oct 11, 2017
This was referenced Oct 11, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2017

Verified the fix works in the latest unreleased insiders

This was referenced Oct 11, 2017
Closed
Closed
Tyriar added a commit that referenced this issue Oct 12, 2017
@Tyriar
Fix blurry terminal font issue introduced in 1.17.1
38e0273 
This pulls in 09c9cb4508bc13a8b5960e06b5eb34f2c93e66f3 from xterm.js, see
xtermjs/xterm.js#1051

Fixes #35991
@ItsNoHax
Copy link

Thanks for the quick fix!

@sjdweb sjdweb mentioned this issue Oct 12, 2017
Closed
@sjdweb
Copy link

sjdweb commented Oct 12, 2017

+1 for quick fix. Any way to downgrade for time being?

@sjdweb sjdweb mentioned this issue Oct 12, 2017
Closed
@wizardion
Copy link

+1 Thanks for the quick fix!

@Tyriar Tyriar mentioned this issue Oct 12, 2017
Closed
@deejayxd07
Copy link

+1 for the quick fix!

@egamma egamma mentioned this issue Oct 13, 2017
Closed
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@Tyriar @sandy081
Fix blurry terminal fonts particularly on low dpi screens
8931478 
Fixes #35991
@chrmarti chrmarti added the verified Verification succeeded label Oct 17, 2017
This was referenced Oct 17, 2017
Closed
Closed
@simonhaenisch
Copy link

The font renders fine again, but I still got this issue on macOS Sierra where the character under the cursor gets pushed up in the first line of the terminal:

screencast

It only happens when I'm in the first line, i. e., after opening the terminal or running clear. Anyone else with this? Could not find an open issue for it.

@Pajn
Copy link

Pajn commented Oct 18, 2017

It does not occur for me, I'm using pure prompt as well.

@simonhaenisch
Copy link

Happens with other prompts as well... how far the character gets pushed up depends on the line the cursor is in:

image

image

image

image

image

From line six on the currently selected character is invisible (which is probably why I thought it was only in the first line).

This didn't happen before updating to 1.17.1. Here is my current info:

  • VSCode Version: Code 1.17.2 (b813d12, 2017-10-16T13:47:41.889Z)
  • OS Version: Darwin x64 16.7.0
  • Reproduces without extensions: Yes

@lucasfernandes4472
Copy link

+1 for the quick fix!

@Tyriar
Copy link
Member

Tyriar commented Oct 18, 2017

@simonhaenisch I cannot repro on Sierra. Can you create a new issue and include your settings.json file?

@simonhaenisch simonhaenisch mentioned this issue Oct 18, 2017
Closed
@ovasquez
Copy link

@Tyriar which was the font used by error in the Terminal? I actually liked it a lot and would like to set it again.

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2017

@ovasquez not sure what other people are using but I use Hack http://sourcefoundry.org/hack/

@Tyriar Tyriar mentioned this issue Oct 28, 2017
Closed
@gonssal
Copy link

gonssal commented Nov 15, 2017 •
edited

vscode-terminal

editor.fontFamily set to "Verdana".

(K)Ubuntu 17.10. Unusable.

@chrmarti
Copy link
Contributor Author

@gonssal Could you open a new issue for this? Thanks.

@gonssal gonssal mentioned this issue Nov 15, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
September Recovery #2 2017
Development

No branches or pull requests