Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support refactoring across multiple projects in a workspace. #48905

Closed
justinfagnani opened this issue Apr 28, 2018 · 6 comments
Closed

Support refactoring across multiple projects in a workspace. #48905

justinfagnani opened this issue Apr 28, 2018 · 6 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@justinfagnani
Copy link

If I open several projects in a workspace, I'd like refactorings to apply across the projects. For instance, when renaming a class field in one project that a dependencies of the others, the field should update in the other projects as well.

@vscodebot
Copy link

vscodebot bot commented Apr 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 30, 2018

What language are you working in?

@justinfagnani
Copy link
Author

TypeScript

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 30, 2018

By multiple projects do you mean multiple tsconfig.jsons?

@justinfagnani
Copy link
Author

Yes. Specifically we have a monorepo setup with Lerna, and a standard .code-workspace file checked in with all of our packages in it.

Within a workspace there are a few things that don't quite work as well as they could besides refactoring, ex: jump to definition opens the .d.ts file of another package, instead of the original source.

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 19, 2018

@justinfagnani I believe this falls under TypeScript 3.0's new project references support. When using project references, I expect that rename and other refactorings apply to linked projects as well. Without them, we treat each project as independent.

Let me know if you don't see refactoring working as expected when using project references

@mjbvz mjbvz closed this as completed Jul 19, 2018
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) typescript Typescript support issues labels Jul 19, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants