Do not change touchbar buttons when stepping

[weimarcoro]

Issue Type: Feature Request

Whe you are debuggin code and you are trying to step over many times (and more or less fast) like you are pressing the normal F10 key in a normal keyboard, the status of the touch bar display sometimes changes the possitions of the debug options which in many times caused me to stop and restart the application accidentally (because the options changed positions. Restart option instead of Step Over in this case).
It would be awesome to provide a fixed debugging display for the touch bar when performing a debug so you are safe to step over fast and many times without restarting the app by accident. if not, a way to configure the touch bar behavior to do just that, fix the debug options.
I guess the touch bar options change because of the context and since the debug context changes a lot, it make sense to change the options but keep in mind that in a normal keyboard, we have all the options as FX options and we are safe to step over many times pressing F10 for example. I just would like the same freedom in my Touch Bar since I don't have FX buttons.

VS Code version: Code 1.25.0 (0f080e5, 2018-07-05T13:02:28.333Z)
OS version: Darwin x64 17.6.0

[isidorn]

So the issue is that the order of the action in the mac touch bar changes. We could fix this by showing the invalid actions as disabled (instead of not showing them).
Code pointer
We would use the precondition instead of the when clause.

Not sure what other apps are doing and what is standrad behavior. Let's leave this open for now to gather more feedback

fyi @bpasero @weinand

[bpasero]

@isidorn @weimarcoro I cannot reproduce this behaviour, but I am also not having a macbook with native touch bar (I am using the touchbar simulator). Is this while debugging TypeScript?

[weimarcoro]

Hi @bpasero I can easily reproduce this behavior by debugging c# code. For example, if you have a function that takes 2 or more seconds to return data (EF long query could be) you can see the buttons at the touch bar changing while waiting for the data to return. "Step over" and other buttons disappear and Restart button appears at the position of the other buttons which leads me to "Restart" accidentally the application.

[weimarcoro]

[billba]

Appears to be duplicate of #48720

[isidorn]

@billba thanks, yeah lets close that one, this one I prefer the description

[bpasero]

I am using a bunch of debug provided context keys, so maybe I need different keys to support this scenario better. The code starts from here:

https://github.com/Microsoft/vscode/blob/eec79d70207c5cf052b2ead3c055c14e788d8642/src/vs/workbench/parts/debug/electron-browser/debug.contribution.ts#L456

[isidorn]

A PR that fixes this is more than welcome.
Someone with a mac touch bar could help here.
@bpasero already provided a code pointer

[chamons]

@isidorn This is the issue I showed you in person.

[isidorn]

@chamons thanks. Let me assign to May to investigate if we can fix this.

[isidorn]

Verifier:
Use a macbook with a new touch bar, or use a touchbar simulator - the simulator works great!
Start debugging, verify that the location of the step buttons on the touch bar does not change as you are stepping through code. And that you can click on the step over button like crazy.

[RMacfarlane]

For some reason, I'm now seeing the actions printed as text instead of icons on VS Code insiders:

I've looked through my settings to try to find what would be causing this and haven't found anything, they appear as icons on stable.

[isidorn]

@RMacfarlane Great catch. This happened due to the move from electron-browser to browser and we forgot to update the import path.

[weinand]

Icons are now showing up again!