Outline remember previous file scroll position

[hunghw]

• VSCode Version: 1.35.0-insider (16de3c2)
• OS Version: Windows_NT x64 10.0.18362

Steps to Reproduce:

1. open two files in the same group
2. scroll the outline in file1 to the bottom, then click file2.

• if the outline list in file1 is more than file2, the outline in file2 will scroll to the bottom.
• if the outline list in file1 is less than file2, the outline in file2 will scroll to the same file1 outline position.

Does this issue occur when all extensions are disabled?: No

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Option for merging single child directories with parent in the file tree (#41627)

[jrieken]

Sorry, I don't understand. Can you attach a gif? Also do you have 'Follow Cursor' enabled?

[hunghw]

@jrieken The outline view will remember the previous file scroll position.

[jrieken]

@jrieken The outline view will remember the previous file scroll position.

Yes, that a feature and by design. What's wrong with that?

[hunghw]

@jrieken I think every file remember their own scroll position is more reasonable.

[jrieken]

Do you have 'Follow Cursor' enabled?

[hunghw]

No, I didn't enable 'follow cursor'.

[jrieken]

That's weird - I can only reproduce this when following the cursor (which is then also the correct behaviour).

[hunghw]

My setting:

• disable 'follow cursor'
• double click two files to let it stay on the editor (fileA has 50 items in Outline and fileB has 100 items)
• scroll fileA's outline to 10th item and click fileB, it will scroll 10th item in fileB.
• scroll fileB's outline to the last item and click fileA, it will scroll to 50th item in fileA. (because fileA doesn't have 100 items.)
• scroll fileA's outline to 1st item and click fileB, it will also scroll to the first item in fileB instead of remembering last scroll position in fileB.

[jrieken]

Ah, same editor... Now I understand. Thanks for clarifying

[jrieken]

@joaomoreno IDataTreeViewState doesn't store the scroll position but I think it would makes sense to do so.

[joaomoreno]

You got it. We have it in the async data tree: https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/tree/asyncDataTree.ts#L268 It's just a matter of porting it.

[jrieken]

@joaomoreno Please double check the change I have pushed 🤞

[joaomoreno]

Awesome @jrieken, thanks!