Review call hierarchy api proposal

[jrieken]

Refs: #70231

• any @aeschli

Complexity: 2

Review the call hierarchy API proposal: https://github.com/Microsoft/vscode/blob/61c990fb6f1a7cdd7ff599156f2002b36b7b079f/src/vs/vscode.proposed.d.ts#L21-L68

[aeschli]

@jrieken in the returned [CallHierarchyItem, Location[]][], wouldn't the locations always be inside the CallHierarchyItem? Does it have to be a Location then, or is Range[] enough?

[jrieken]

Yeah, they are always inside "a" call hierarchy item, e.g the item making the call so either items from the returned tuples or when the arguments. I have no strong feelings, there are more arguments in the LSP item: microsoft/vscode-languageserver-node#420 (comment)

[aeschli]

Discussed with @jrieken. We wrote down a new proposal in #70231 (comment)