Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use existing editor tab from unfocused editor group when hitting a breakpoint #71672

Closed
jarrodldavis opened this issue Apr 3, 2019 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jarrodldavis
Copy link

Issue Type: Feature Request

Currently, when a breakpoint is hit in a file open in an unfocused tab from an unfocused editor group, VS Code creates a new tab for that file in the currently focused editor group. Instead, it should re-use the existing tab and move focus to it.

VS Code version: Code 1.32.3 (a3db5be, 2019-03-14T22:46:48.547Z)
OS version: Darwin x64 18.2.0

Here is a screen recording illustrating the issue:

https://jmp.sh/gbienyu

@isidorn
Copy link
Contributor

isidorn commented Apr 4, 2019

This makes sense imho, however the editorService.openEditor needs to support that option.
Currently it has SIDE_GROUP and ACTIVE_GROUP. It seems it should also have GROUP_THAT_CONTAINS_EDITOR or something like that.
@bpasero or is there already something like that?

@isidorn isidorn added debug-console feature-request Request for new features or functionality labels Apr 4, 2019
@isidorn isidorn added this to the Backlog milestone Apr 4, 2019
@bpasero
Copy link
Member

bpasero commented Apr 4, 2019

@isidorn isidorn added the verification-needed Verification of issue is requested label Apr 4, 2019
@isidorn isidorn modified the milestones: Backlog, April 2019 Apr 4, 2019
@isidorn isidorn closed this as completed in af5e777 Apr 4, 2019
@joaomoreno joaomoreno added the verified Verification succeeded label May 7, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants