Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcut(s) Changed? #81552

Closed
jtsom opened this issue Sep 27, 2019 · 10 comments
Closed

Keyboard Shortcut(s) Changed? #81552

jtsom opened this issue Sep 27, 2019 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded

Comments

@jtsom
Copy link

jtsom commented Sep 27, 2019

Issue Type: Bug

On Windows, when did the default keyboard shortcut for "Task: Run Build Task" get removed? On Windows it used to be Ctrl-Shift-B. It exists on the MacOS, and the latest Exploration version it exists. Yes, I can add it back, but why was it removed?

VS Code version: Code - Insiders 1.39.0-insider (e0762af, 2019-09-27T05:26:42.235Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (4 x 2592)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: unavailable_off
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 12.00GB (6.82GB free)
Process Argv
Screen Reader no
VM 100%
Extensions (18)
Extension Author (truncated) Version
ng-template Ang 0.802.3
vscode-eslint dba 1.9.1
auto-close-tag for 0.5.6
auto-rename-tag for 0.1.0
output-colorizer IBM 0.1.2
Angular2 joh 8.1.1
vscode-peacock joh 3.1.5
vscode-azurefunctions ms- 0.18.1
vscode-azurestorage ms- 0.7.1
vscode-cosmosdb ms- 0.11.0
azure-account ms- 0.8.4
csharp ms- 1.21.3
vscode-typescript-tslint-plugin ms- 1.2.2
debugger-for-chrome msj 4.12.0
vetur oct 0.22.3
material-icon-theme PKi 3.9.0
quicktype qui 12.0.46
vscodeintellicode Vis 1.1.9

(4 theme extensions excluded)

@IllusionMH
Copy link
Contributor

Strange. I can see shortcut in TypeScript repo, but not in other repos. Event with extension disabled.

However default shortcut is still there, but not visible in Command palette (even with extensions disabled)

{ "key": "ctrl+shift+b",          "command": "workbench.action.tasks.build" },

@jtsom
Copy link
Author

jtsom commented Sep 27, 2019

Yep, it's not there as a default at all (only shows my "User" entry I had to make):

image

@IllusionMH
Copy link
Contributor

I was able to reproduce this issue, but as mentioned above - I can see shortcut in workspace for TypeScript repo, but unable to see it in workspace for vscode repo or local folder that has .vscode/tasks.json and even task marked as default.

I switch between workspaces with File > Open recent.

@alexr00
Copy link
Member

alexr00 commented Sep 30, 2019

In the keyboard shortcuts UI can you search for ctrl+shift+b to see if there is another binding? If an extension contributes a keybinding for ctrl+shift+b then it would override the default tasks build shortcut.

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Sep 30, 2019
@jtsom
Copy link
Author

jtsom commented Sep 30, 2019

Nope. None that I'm aware of.

@IllusionMH
Copy link
Contributor

IllusionMH commented Sep 30, 2019

@alexr00 for me Ctrl+Shift+B became missing after few window reloads, opening another recent workspace (File > Open Recent or from Welcome tab), opening new windows (File > New Window).

Looks like there are cases when this shortcut is not added immediately. I captured case when shortcut was added only after I executed >Preferences: Open Default Keyboard Shortcuts (JSON) (no window reload or opening new window between these screenshots)

  1. Before
    image
  2. After opening
    image

However I had cases when I found commented workbench.action.tasks.build in // Here are other available commands: section.

OK, couple window reloads and
image
image

Please note - I was able to reproduce this issue after using >Developer: Restart With Extensions Disabled or launching from CLI code-insiders --disable-extensions ..

Sometimes it may be noticed in first opened workspace, sometime its in new window or after few switches between recently opened workspace

@alexr00
Copy link
Member

alexr00 commented Sep 30, 2019

@IllusionMH lots of good details, thank you. I just repro'd it and am investigating.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues and removed info-needed Issue requires more information from poster labels Sep 30, 2019
@alexr00 alexr00 added this to the September 2019 milestone Sep 30, 2019
@alexr00
Copy link
Member

alexr00 commented Sep 30, 2019

I repro'd this once then I couldn't get it to happen again. I've moved the registration of the keybinding to be earlier which I hope will fix it.

Please do download insiders tomorrow and see if it's still happening!

@IllusionMH
Copy link
Contributor

@alexr00 looks OK after update. 👍
I've tried several times cases described above and haven't seen problem to reappear.

@alexr00
Copy link
Member

alexr00 commented Oct 1, 2019

Thank you for verifying!

@alexr00 alexr00 added the verified Verification succeeded label Oct 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants