Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently opened: "workspaces" vs "(Workspace)" is confusing #93942

Closed
Tyriar opened this issue Mar 31, 2020 · 4 comments
Closed

Recently opened: "workspaces" vs "(Workspace)" is confusing #93942

Tyriar opened this issue Mar 31, 2020 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster quick-pick Quick-pick widget issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93729

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362


Using the example image from #93729:

image

The blue "workspaces" label tells the user that all items in this group are workspaces, but then one of them is explicitly marked as a "Workspace". Should this be additionally separated into "files", "folders" and "workspaces" to avoid this? That way we could remove the (Workspace) indicator.

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

@Tyriar I do not think separating between folders and workspaces is clever because I for example frequently switch between single folder workspaces and multi-root. This would basically prevent me from being able to quickly switch to the previous one.

Open for more ideas.

@bpasero bpasero added the info-needed Issue requires more information from poster label Mar 31, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Mar 31, 2020

Could it be "Folders and Workspaces" then? "Folders/Workspaces" could be even better but it's used in view to show hierarchy:

image

@bpasero bpasero added this to the March 2020 milestone Apr 1, 2020
@bpasero bpasero added the quick-pick Quick-pick widget issues label Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Upon second thought, I am not sure explicitly calling out "folders" and "workspaces" is helpful to understand the intent. I think #77718 is the discussion to have on this topic.

/duplicate #77718

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @Tyriar and others