Take changelog from remote if provided #12455
Conversation
|
Hi @XVincentX, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
@joaomoreno Last part is here! |
| @@ -108,7 +108,7 @@ class Extension implements IExtension { | |||
| return this.local.changelogUrl; | |||
| } | |||
|
|
|||
| return ''; // Hopefully we will change this once the gallery will support that. | |||
| return this.gallery && this.gallery.assets.changelog; | |||
There was a problem hiding this comment.
This was the wrong place. You should do it in the hasChangelog and getChangelog. While you're at it, just delete the readmeUrl and changelogUrl; the former was an old implementation which I forgot to delete.
There was a problem hiding this comment.
Actually no...
Make those two getters private and use them in the getReadme and getChangelog methods to get a hold of the URL.
|
Coverage remained the same at 61.186% when pulling 769b96a25c2d921554d23d4cbab721d53b500553 on XVincentX:master into 4e09528 on Microsoft:master. |
|
Addressed in 154a45c @joaomoreno |
|
Coverage increased (+0.003%) to 61.19% when pulling 154a45c8104f465aee0feaa29abbd43326f8e26d on XVincentX:master into 4e09528 on Microsoft:master. |
|
@joaomoreno I think I made a mistake here while rebasing my fork. |
|
Hi @XVincentX, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
Ok I managed to reopen it. |
|
Hi @XVincentX, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
Thanks @XVincentX, great work!! |
|
I can't wait to see it live! |
The following PR should be the missing part to make #11940