Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cropped/crippled telemetry event worries #127789

Closed
jrieken opened this issue Jul 1, 2021 · 4 comments
Closed

Cropped/crippled telemetry event worries #127789

jrieken opened this issue Jul 1, 2021 · 4 comments
Assignees
@lramos15 @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders telemetry Telemetry system issues verified Verification succeeded
Milestone
November 2021

Comments

@jrieken
Copy link
Member

jrieken commented Jul 1, 2021

There is places where telemetry events contains large data, often it's about sending JSON-strings as property value. This can yield to problems because property values are simply cut at 1023 characters. This is problematic because
@jrieken
Copy link
Member Author

jrieken commented Jul 1, 2021

fyi @alexdima

@jrieken
Copy link
Member Author

jrieken commented Jul 1, 2021 •
edited

Adding a sample to make this more real: We have performance marks that anyone can add to the source anywhere, like here or here.

All performance marks can be retrieved in a single call and it would be helpful to send them as one event but that doesn't work because the data is too large. Instead, each event is send individually which makes this a kusto nightmare because these event must all be correlated on a session id.

source pointer:

vscode/src/vs/workbench/services/timer/browser/timerService.ts

Line 541 in 89731c8

this._telemetryService.publicLog2<Mark, MarkClassification>('startup.timer.mark', {

@sbatten sbatten added telemetry Telemetry system issues bug Issue identified by VS Code Team member as probable bug labels Oct 4, 2021
@sbatten sbatten added this to the Backlog milestone Oct 4, 2021
@lramos15 lramos15 closed this as completed Nov 3, 2021
@lramos15 lramos15 reopened this Nov 3, 2021
@lramos15 lramos15 modified the milestones: Backlog, October 2021 Nov 3, 2021
@lramos15
Copy link
Member

lramos15 commented Nov 3, 2021

Updated the length to 8192 and added a warning to note when properties are getting truncated

@alexr00 alexr00 added candidate Issue identified as probable candidate for fixing in the next release and removed candidate Issue identified as probable candidate for fixing in the next release labels Nov 3, 2021
@lramos15 lramos15 modified the milestones: October 2021, November 2021 Nov 3, 2021
@jrieken jrieken added the verified Verification succeeded label Nov 30, 2021
@jrieken
Copy link
Member Author

jrieken commented Nov 30, 2021

I have even seen the warning!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders telemetry Telemetry system issues verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
5 participants
@jrieken @lramos15 @sbatten @alexr00 and others